-
Notifications
You must be signed in to change notification settings - Fork 441
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test_runner/performance: add logical message ingest benchmark #9749
base: main
Are you sure you want to change the base?
Conversation
actually, pageservers need to ingest some logical messages as part of aux file implementation -> neon/pageserver/src/walingest.rs Lines 242 to 245 in 10aaa36
but the ones created in the test case will likely be dropped by the pageserver in the end |
...aux file logical messages begin with |
5490 tests run: 5247 passed, 0 failed, 243 skipped (full report)Code coverage* (full report)
* collected from Rust tests only The comment gets automatically updated with the latest test results
9a82514 at 2024-11-18T11:48:29.354Z :recycle: |
Would you mind noting the results you currently get in the PR description? I find this useful when looking back at history of benchmarks (even though we also have some history in a database) |
Sure, added a result from my MacBook, but I don't think it's particularly useful without more context and representative hardware. For running analysis, see #9642 (comment). |
Adds a benchmark for logical message WAL ingestion throughput end-to-end. Logical messages are essentially noops, and thus ignored by the Pageserver.
Example results from my MacBook, with fsync enabled:
See #9642 (comment) for running analysis.
Touches #9642.