Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pageserver: only store SLRUs on shard zero #9786

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

jcsp
Copy link
Collaborator

@jcsp jcsp commented Nov 18, 2024

Problem

Since #9423 the non-zero shards no longer need SLRU content in order to do GC. This data is now redundant on shards >0.

Closes: #7512

Summary of changes

  • Avoid storing SLRUs on non-zero shards
  • Avoid storing checkpoint on non-zero shards

@jcsp jcsp changed the title Jcsp/slrus on shard 0 pt2 pageserver: only store SLRUs on shard zero Nov 18, 2024
Copy link

5499 tests run: 5255 passed, 1 failed, 243 skipped (full report)


Failures on Postgres 17

  • test_timeline_retain_lsn[offload-parent-False]: debug-x86-64
# Run all failed tests locally:
scripts/pytest -vv -n $(nproc) -k "test_timeline_retain_lsn[debug-pg17-offload-parent-False]"
Flaky tests (1)

Postgres 16

Test coverage report is not available

The comment gets automatically updated with the latest test results
001341a at 2024-11-18T11:18:39.689Z :recycle:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pageserver: publish GC cutoff from shard 0, so that other shards don't need to keep SLRUs
1 participant