TASK: Introduce rebase failed exception and deprecate WorkspaceRebaseFailed
#4965
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
10 tasks
kitsunet
approved these changes
Apr 9, 2024
Closed
1 task
bwaidelich
reviewed
Apr 10, 2024
|
yes, the whole publishing/discarding will be overhauled in neos/neos-ui#3744 |
bwaidelich
approved these changes
Apr 10, 2024
3 tasks
mhsdesign
changed the title
WorkspaceRebaseFailed
12 tasks
|
Question: what happens with So can we get rid of this |
|
Yep, it's no longer needed afais |
6 tasks
mhsdesign
added a commit
to mhsdesign/neos-development-collection
that referenced
this pull request
Oct 17, 2024
Via neos#4965 the status REBASE_ERROR is obsolete. Instead of still using this status on replay we mimic the new logic: > In case of a [rebase error}, reopen the old content stream and remove the newly created Additionally, to not break `findContentStreams` when fetching all content streams we make sure that the streams with `REBASE_ERROR` are transformed to `NO_LONGER_IN_USE` so they can be cleaned up. Related neos#5101
mhsdesign
added a commit
to mhsdesign/neos-development-collection
that referenced
this pull request
Jan 26, 2025
…ng the exception message) While before neos#4965 a even `WorkspaceRebaseFailed` would contain bloats of data which grew a lot. A small message in the closed even is not a problem though.
mhsdesign
added a commit
to mhsdesign/neos-development-collection
that referenced
this pull request
Jan 27, 2025
…ng the exception message) While before neos#4965 a even `WorkspaceRebaseFailed` would contain bloats of data which grew a lot. A small message in the closed even is not a problem though.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This deprecates the WorkspaceRebaseFailed event with a likewise named exception.
Applications like the Neos UI need detailed information about what exactly failed. Storing this in an event incapacitates the event store quite fast since the amount of data gets quickly out of hand.
Also, we currently have no application for handling the stored data asynchronously. For endpoints like the Neos UI BackendServiceController we need the feedback directly anyway, so instead of waiting for the event to be serialized and deserialized again, they can deal with an exception a lot better.
All necessary information is stored in said exception and thrown with it, readily available for the initiating user to deal with it
Upgrade instructions
nothing yet
Review instructions
I'm not 100% sure about the workspace / content stream state handling. The conflict state is probably no longer necessary
Related: #4545
Checklist
FEATURE|TASK|BUGFIX!!!and have upgrade-instructions