Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUGFIX: Prevent rendering of SearchBox #3674

Draft
wants to merge 1 commit into
base: 7.3
Choose a base branch
from

Conversation

markusguenther
Copy link
Member

When the displaySearchBox property is false, we should not render the SelectBox that is responsible for the search.

Fixes: #3673

@github-actions github-actions bot added Bug Label to mark the change as bugfix 7.3 labels Dec 18, 2023
When the displaySearchBox property is false, we should not render the SelectBox that is responsible for the search.

Fixes: neos#3673
@markusguenther
Copy link
Member Author

Ok need to check the failing test cases

@Sebobo
Copy link
Member

Sebobo commented Dec 20, 2023

Shouldn't a default value be set for the displaySearchbox?
Also the test needs to be adjusted.

@markusguenther
Copy link
Member Author

@Sebobo It is disabled but with a multi selectbox, you see the disabled box that takes a lot of space and leads to a bad UX.
Screenshot 2023-12-18 at 20 25 47

@markusguenther
Copy link
Member Author

The whole concept of the components regarding select boxes is leading to issues, and it seems not that trivial to remove/hide the search box... need to think about it, and therefore it will not make it into the pre-Christmas release.

@markusguenther markusguenther marked this pull request as draft January 15, 2024 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
7.3 Bug Label to mark the change as bugfix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants