Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUGFIX: 3839 show warn dialog before ckeditor formatting gets lost #3842

Draft
wants to merge 2 commits into
base: 8.3
Choose a base branch
from

Conversation

mhsdesign
Copy link
Member

@mhsdesign mhsdesign commented Aug 26, 2024

Resolves: #3839

Bildschirmaufnahme.2024-08-26.um.16.03.48.mov

What I did

How I did it

How to verify it

@github-actions github-actions bot added Bug Label to mark the change as bugfix 8.3 labels Aug 26, 2024
Copy link
Contributor

@grebaldi grebaldi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good after a first quick skim, but I noticed a naming issue:

derivation, *Derivation should be deviation, *Deviation, because

English German
derivation Ableitung
deviation Abweichung

@mhsdesign mhsdesign force-pushed the bugfix/3839-ckeditor-warn-dialog-before-formatting-getting-lost branch from be5ca0f to c40ef35 Compare September 5, 2024 11:16
@mhsdesign mhsdesign changed the base branch from 8.3 to bugfix/3839-ckeditor-only-save-changes-if-dirty September 5, 2024 14:10
Base automatically changed from bugfix/3839-ckeditor-only-save-changes-if-dirty to 8.3 September 9, 2024 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
8.3 Bug Label to mark the change as bugfix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants