-
-
Notifications
You must be signed in to change notification settings - Fork 135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TASK: Run acceptance tests also on chrome #3862
base: 8.3
Are you sure you want to change the base?
Conversation
4506a80
to
6de3e09
Compare
294fdaf
to
9919071
Compare
platformName: "Windows 10" | ||
screenResolution: "1280x1024" | ||
- name: "One dimensional Tests in Edge on MacOS" | ||
browserName: "microsoftedge" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why not chrome? ^^
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It was just a try, in safari we also have issues in the tests ;)
@@ -3,7 +3,7 @@ kind: testcafe | |||
sauce: | |||
region: us-west-1 | |||
concurrency: 1 # Controls how many suites are executed at the same time. | |||
retries: 0 | |||
retries: 3 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
retries / smart retries dont work as far as i tried.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While testing the PR for 8.4 I had the case that one run failed and the retry succeeded. But did not enforce it after that.
@@ -40,20 +40,6 @@ const SETTINGS_WITH_NODE_TREE_PRESETS = { | |||
presets: { | |||
'default': { | |||
baseNodeType: 'Neos.Neos:Document,!Neos.TestNodeTypes:Document.Blog,!Neos.TestNodeTypes:Document.BlogArticle' | |||
}, | |||
'blog': { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i think we should try to keep it and make it work on chrome. I dont know why it doesnt work in ci. Locally it works splendidly. We have to debug the http request
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I had the issue also locally, and therefore I changed this and also did not see why we need to change it. But I was not involved in the change back then.
No description provided.