-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update nerfstudio_dataparser.py #2801
Conversation
load-3D-points set to True by default
Hm yeah, it seems reasonable to make these two consistent. But this change only impacts non-splatting methods where the points aren't used, right? (like nerfacto) For the nerfstudio dataparser, this is currently overridden to nerfstudio/nerfstudio/configs/method_configs.py Lines 601 to 603 in 8952fb5
I also verified this in the helptext from |
yeah, you are alright. The |
Are there any other methods that will use the points? The one argument I see for keeping the discrepancy is that the colmap parser always has points available, while the nerfstudio parser only sometimes has points. If we always set nerfstudio/nerfstudio/data/dataparsers/nerfstudio_dataparser.py Lines 392 to 395 in 8952fb5
This might be confusing for people. |
should this be closed? |
Okay, let close it since you said this:
|
This is initial code:
nerfstudio/nerfstudio/data/dataparsers/nerfstudio_dataparser.py
Line 76 in 8952fb5
I fix to
--load-3D-points
set to True by default.Why I set True by default? Because I see another recommendation in this line for set it true
nerfstudio/nerfstudio/data/dataparsers/colmap_dataparser.py
Line 96 in 8952fb5
Meanwhile, we already switching from colmap dataparser to nerfstudio dataparser #2791