Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#2783 fixed an issue where the
fisheye_crop_radius
metadata field was being accidentally deleted. Unfortunately this also brokenerfacto
support for Aria, since it exposed some broken fisheye sampling logic from #2617 (which was previously not being run).Specific fixed problems:
image_height // 2
andimage_width // 2
, since the crop radius is already in pixel units.These changes + #2783 reduce artifacts.
Before:
aria-nerfstudio-render.mp4
After:
2024-02-22-21-27-52.mp4