Add more info to the README #2
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ners
requested changes
Sep 8, 2023
Comment on lines
+36
to
+45
| And then import and enable it like this: | ||
| ```nix | ||
| { | ||
| imports = [ | ||
| inputs.nix-monitored.nixosModules.default | ||
| ]; | ||
|
|
||
| nix.monitored.enable = true; | ||
| } | ||
| ``` |
There was a problem hiding this comment.
Importing and enabling the module actually replaces setting nix.package manually, as that's part of the module's implementation: https://github.com/ners/nix-monitored/blob/master/flake.nix#L108
I'd also like to mention that there is also a Darwin module available, not just a NixOS one.
Comment on lines
+47
to
+50
| You can also import it in the overlay below by putting this line inside alongside the rest: | ||
| ``` | ||
| nix-monitored = inputs.nix-monitored.packages.${self.system}.default.override self; | ||
| ``` |
There was a problem hiding this comment.
This should probably rather be added to the module: https://github.com/ners/nix-monitored/blob/master/flake.nix#L109
| @@ -44,6 +59,7 @@ nixpkgs.overlays = [ | |||
| nix-direnv = super.nix-direnv.override { | |||
| nix = super.nix-monitored; | |||
| }; | |||
| # Line above here if you want it. | |||
There was a problem hiding this comment.
I believe this entire section is obsolete if you use the module, and can be removed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Specifically how to set up the module.