Early return success when writing 0

nervosnetwork · Nov 18, 2024 · 2b350fb · 2b350fb
1 parent b1b841f
commit 2b350fb
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 0 deletions.
diff --git a/src/syscalls/native.rs b/src/syscalls/native.rs
@@ -738,6 +738,9 @@ pub fn read(fd: u64, buffer: &mut [u8]) -> Result<usize, SysError> {
 /// Note: available after ckb 2nd hardfork.
 pub fn write(fd: u64, buffer: &[u8]) -> Result<usize, SysError> {
     let mut l: u64 = buffer.len() as u64;
+    if l == 0 {
+        return Ok(0);
+    }
     let ret = unsafe {
         syscall(
             fd,

diff --git a/src/syscalls/simulator.rs b/src/syscalls/simulator.rs
@@ -345,6 +345,9 @@ pub fn read(fd: u64, buffer: &mut [u8]) -> Result<usize, SysError> {
 
 pub fn write(fd: u64, buffer: &[u8]) -> Result<usize, SysError> {
     let mut l = buffer.len();
+    if l == 0 {
+        return Ok(0);
+    }
     let ret = sim::ckb_write(fd, buffer.as_ptr() as *mut c_void, &mut l as *mut usize) as u64;
     match ret {
         0 => Ok(l as usize),