Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement FlattenedArgsReader #450

Merged
merged 3 commits into from
Jan 17, 2025
Merged

Implement FlattenedArgsReader #450

merged 3 commits into from
Jan 17, 2025

Conversation

mohanson
Copy link
Collaborator

Changed args format from args: &[Bytes] to args: impl ExactSizeIterator<Item = Result<Bytes, Error>> to achieve simpler and more efficient cross-vm args reading.

@mohanson mohanson force-pushed the args_reader branch 3 times, most recently from 59113bf to b1b4b00 Compare January 16, 2025 13:38
@mohanson mohanson mentioned this pull request Jan 17, 2025
Open
xxuejie
xxuejie reviewed Jan 17, 2025
View reviewed changes
benches/vm_benchmark.rs Show resolved Hide resolved
benches/vm_benchmark.rs Outdated Show resolved Hide resolved
src/memory/mod.rs Outdated Show resolved Hide resolved
@mohanson mohanson merged commit e9d9b18 into nervosnetwork:develop Jan 17, 2025
11 checks passed
@mohanson mohanson deleted the args_reader branch January 17, 2025 05:37
mohanson added a commit to libraries/ckb-vm that referenced this pull request Jan 17, 2025
@mohanson
Backport nervosnetwork#450
b800758
mohanson added a commit that referenced this pull request Jan 17, 2025
@mohanson
Backport #450 and #446 (#452)
704f410 
* Backport #450

* Fix the error given by deny (#446)

* Fix the error given by deny

* Allow Unicode-3.0 License
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xxuejie xxuejie xxuejie approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mohanson @xxuejie