Send channel tlc info directly to counterparty and update network graph with owned channel information #446
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
contrun
force-pushed
the
update-channel-info-with-counterparty
branch
from
a338f8f to
7fadd70
Compare
contrun
force-pushed
the
update-channel-info-with-counterparty
branch
from
84a2710 to
f2346fb
Compare
contrun
force-pushed
the
update-channel-info-with-counterparty
branch
from
185f659 to
4686404
Compare
contrun
force-pushed
the
update-channel-info-with-counterparty
branch
from
144cde1 to
12a8555
Compare
…nel-info-with-counterparty
contrun
force-pushed
the
update-channel-info-with-counterparty
branch
from
86f3e48 to
cf3d47c
Compare
contrun
force-pushed
the
update-channel-info-with-counterparty
branch
from
794077d to
2353f37
Compare
contrun
force-pushed
the
update-channel-info-with-counterparty
branch
from
2353f37 to
0d996cd
Compare
contrun
force-pushed
the
update-channel-info-with-counterparty
branch
from
20c5b5c to
dfb2683
Compare
contrun
changed the title
|
This PR added new fields to |
quake
reviewed
Jan 14, 2025
src/fiber/channel.rs
Outdated
| state | ||
| .generate_and_broadcast_channel_update(&self.network) | ||
| .await; | ||
| state.notify_owned_channel_updated(&self.network).await; |
There was a problem hiding this comment.
handle_update_command only update our part of channel, I think we should send OwnedChannelUpdateEvent::Updated instead of OwnedChannelUpdateEvent::Up here.
quake
approved these changes
Jan 14, 2025
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.