Fix issue 2291 #2309
Merged
Fix issue 2291 #2309
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In case that no parameter or undefined is passed to the spr function in JS, the parameter would evaluate to 0 due to a wrong default value in the code path when colorkey is not an array. In case of an array the default value would be -1, which is also specified in the wiki. We now pass -1 in case the parameter is not an array. See: nesbox#2291
|
Let me just add a link to: issue #2291. |
nesbox
approved these changes
Sep 23, 2023
Eulenmensch93
deleted the
fix_2291_unexpected_spr_rendering_with_undefined_colorkey
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As described in issue 2291, the code to handle the colorkey parameter in the spr function did not use the correct default value in one of the two code paths.
We now pass the correct default value to getInteger2, this handles cases where the parameter is not present, and where the parameter is
undefinedin JS.