Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Travis build on OSX #1183

Merged
merged 25 commits into from
Jun 6, 2019
Merged

Travis build on OSX #1183

merged 25 commits into from
Jun 6, 2019

Conversation

lekshmideepu
Copy link
Contributor

@lekshmideepu lekshmideepu commented Apr 18, 2019

Added the best possible maximal build for OSX Mojave which fixes #639
MUSIC is turned OFF due to the non-availability of MPI-CXX bindings in Openmpi4.0.1 (Refer INCF/MUSIC#27 (comment)).
Fixes the incorrect nest.init call #1181 and module import error mentioned in #1180

@lekshmideepu lekshmideepu requested a review from jougs April 18, 2019 07:47
@jougs jougs requested a review from tammoippen April 18, 2019 08:01
@jougs jougs added ZC: Infrastructure DO NOT USE THIS LABEL I: No breaking change Previously written code will work as before, no one should note anything changing (aside the fix) ZP: PR Created DO NOT USE THIS LABEL S: High Should be handled next T: Enhancement New functionality, model or documentation labels Apr 18, 2019
Copy link
Contributor

@jougs jougs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Many thanks providing this extremely useful addition. I have a more structural change request and a suggestion for the wording of a comment. Other than that I'm happy to approve once the Travis run is finished.

extras/travis_build.sh Outdated Show resolved Hide resolved
extras/travis_build.sh Outdated Show resolved Hide resolved
@jougs
Copy link
Contributor

jougs commented Apr 18, 2019

I observe exactly the same hang of the MPI testsuite with Open MPI 3.1.3 on Linux. As it sometimes works without problems, I suggest some race condition going on. We really should fix our data exchange in the MPI based testing with SLI. For now, I'm fine with just disabling it here, although I think @heplesser should also have a look.

@lekshmideepu lekshmideepu requested a review from jougs April 24, 2019 14:49
Copy link
Contributor

@jougs jougs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Many thanks for addressing my comments. I think this really is a huge step forward for us and I'm all in favor of merging it.

@jougs
Copy link
Contributor

jougs commented May 7, 2019

@tammoippen, would you be available to review this PR? Thanks!

extras/travis_build.sh Outdated Show resolved Hide resolved
.travis.yml Show resolved Hide resolved
extras/travis_build.sh Outdated Show resolved Hide resolved
extras/travis_build.sh Outdated Show resolved Hide resolved
extras/travis_build.sh Show resolved Hide resolved
extras/travis_build.sh Outdated Show resolved Hide resolved
.travis.yml Show resolved Hide resolved
.travis.yml Show resolved Hide resolved
Copy link
Contributor

@tammoippen tammoippen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. The gcc selection will break for the next major release, but until then we have some time. Should probably be something like:

grep '^/usr/local/bin/gcc-\d+$

Best.

@jougs
Copy link
Contributor

jougs commented Jun 6, 2019

Awesome. I'm merging.

I'd also like to thank @tammoippen for reviewing @lekshmideepu for putting so much hard work into this - the punishment is over ;-)

@jougs jougs merged commit fe97a6d into nest:master Jun 6, 2019
@lekshmideepu
Copy link
Contributor Author

:-) Thanks @jougs

@tammoippen
Copy link
Contributor

I am happy to assist 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
I: No breaking change Previously written code will work as before, no one should note anything changing (aside the fix) S: High Should be handled next T: Enhancement New functionality, model or documentation ZC: Infrastructure DO NOT USE THIS LABEL ZP: PR Created DO NOT USE THIS LABEL
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Travis build jobs on multiple OSs(OSX,Linux)
3 participants