Fixes problem when local_port is set to zero #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If you set local_port to zero then the local port will get randomly assigned by socket but currently won't get recorded in actual_local_port. If you are goign to start multiple instances of net-ssh-gateway at the same time then there is a chance that the next_port method could select the same local port as another instance so setting local_port=0 is safer.
| @@ -85,6 +85,11 @@ def active? | |||
| @active | |||
| end | |||
|
|
|||
| # Returns the gateway host being used for the tunnel | |||
| def host? | |||
There was a problem hiding this comment.
this should be just host no question mark
|
Close as stale? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you set local_port to zero then the local port will get randomly assigned by socket but currently won't get recorded in actual_local_port.
If you are goign to start multiple instances of net-ssh-gateway at the same time then there is a chance that the next_port method could select the same local port as another instance so setting local_port=0 is safer.