AP routed domain input validation needs to be updated to make vlan_pool an optional value #76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
moskrive
requested changes
May 7, 2024
There was a problem hiding this comment.
Additional code changes in the Terraform module to enable routed domains without a VLAN pool associate.
These ares includes:
- aci_access_policies.tf script to make the VLAN pool attribute optional and only provided it if defined
- terraform-aci-routed-domain sub module to the VLAN pool optional in the terraform code and configure the VLAN pool reference object when defined
danischm
changed the title
Hi morten, I updated the first file requested, please check and confirm it is what you expected. could you provide more information on the 2nd request please as i dont understand what is required? |
moskrive
approved these changes
May 24, 2024
danischm
approved these changes
May 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
update to documentation based on changes here
https://wwwin-github.cisco.com/netascode/aac/pull/337