-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add 4 new FT's | GRE Int , Cellular Int, Cellular Controller, Cellular Profile #74
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- add support for sdwan_cellular_controller_feature_template resource - add support for sdwan_cellular_cedge_profile_feature_template resource - add support for sdwan_cisco_vpn_interface_gre_feature_template resource
tzarski0
reviewed
Dec 2, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sdwan_vpn_interface_cellular_feature_template has bug in the provider that should be fixed before we release this
upgraded my environment to 0.5.3 and tested. The fix is still valid. It's good to merge. |
tzarski0
approved these changes
Jan 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add features requested in
https://wwwin-github.cisco.com/netascode/nac-sdwan/issues/328
https://wwwin-github.cisco.com/netascode/nac-sdwan/issues/329
https://wwwin-github.cisco.com/netascode/nac-sdwan/issues/330
Note
I encountered an issue with the provider not supporting this feature being attached to a device template.
I encountered an issue with the provider not supporting value "hub" for tunnel_qos_mode in Cellular Interface
Provider fix was built and merged CiscoDevNet/terraform-provider-sdwan#377 and will be publicly available with 0.5.2 release https://registry.terraform.io/providers/CiscoDevNet/sdwan/latest