Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

profiles: refactor log viewers #5996

Merged
merged 2 commits into from
Sep 23, 2023
Merged

profiles: refactor log viewers #5996

merged 2 commits into from
Sep 23, 2023

Conversation

glitsj16
Copy link
Collaborator

@glitsj16 glitsj16 commented Sep 9, 2023

Introduces a common profile for existing GUI log viewer applications.

@kmk3 kmk3 changed the title refactor log viewers profiles: refactor log viewers Sep 10, 2023
@glitsj16 @kmk3
profiles: refactor log viewers
4b9da8d 
Introduces system-log-common.profile as a common profile for existing
GUI log viewer applications.
kmk3
kmk3 approved these changes Sep 21, 2023
View reviewed changes
Copy link
Collaborator

@kmk3 kmk3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: It's a bit hard to figure out what are the common lines that are being
moved and what is actually being changed (that is, how this affects the
existing profiles), but at least the new file looks good to me.

I'd suggest trying to split these 2 types of changes in future PRs if possible
to make them easier to review.

@glitsj16
Copy link
Collaborator Author

I'd suggest trying to split these 2 types of changes in future PRs if possible
to make them easier to review.

@kmk3 I'll keep that in mind. Thanks for reviewing, however uneasy!

@glitsj16 glitsj16 merged commit dd55390 into netblue30:master Sep 23, 2023
3 checks passed
@glitsj16 glitsj16 deleted the log-viewers branch September 23, 2023 01:42
@glitsj16
Copy link
Collaborator Author

@kmk3 Something went very bad with this PR. At first I thought the newly introduced system-log-common.profile was missing. But apparently it's placed under /etc/profile-m-z/profile-m-z/. Not sure how I did that but it's obviously NOT the correct place to put it. I realize it's my mistake, hence I should fix it. But I don't want to create a bigger mess by randomly fireing git commands I don't feel familiar with in this context. Can you help to get this fixed properly please?

kmk3 added a commit that referenced this pull request Sep 23, 2023
@kmk3
profiles: fix path of system-log-common.profile
f5534fb 
This amends commit dd55390 ("profiles: refactor log viewers (#5996)",
2023-09-23).

Commands used:

    git mv \
      etc/profile-m-z/profile-m-z/profile-m-z/system-log-common.profile \
      etc/profile-m-z/system-log-common.profile
    rmdir etc/profile-m-z/profile-m-z/profile-m-z/
    rmdir etc/profile-m-z/profile-m-z/
@kmk3
Copy link
Collaborator

kmk3 commented Sep 23, 2023

@glitsj16 All good; fixed on commit f5534fb ("profiles: fix path of
system-log-common.profile", 2023-09-23).

@glitsj16
Copy link
Collaborator Author

@kmk3 Thanks for your kind and knowledgeable work!

This was referenced Aug 25, 2024
Closed
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kmk3 kmk3 kmk3 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@glitsj16 @kmk3