Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workaround: #37 - Added base pathing in static js #39

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

lc787
Copy link

@lc787 lc787 commented Aug 6, 2024

Workaround for #37
Okay, so the static files edit.js and utils.js don't really have a mechanism for relative path referencing. I've patched the scripts so it should be fine now. Unfortunately, I couldn't find a way to not hard-code netbox_root, but at least I got it in one place only so the workaround isn't hard to apply. Mind you, I'm not a frontend developer, so I don't know how feasible it is to do this without a build process.

@lc787
Copy link
Author

lc787 commented Aug 6, 2024

There are a couple of hrefs that still don't work. The buttons 'Edit Floorplan' and 'Add Floorplan' under {netbox_root}/dcim/sites/{id}/floorplans/ for example. I'm not sure how the plugin framework works in netbox so I've yet to take a crack at it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant