Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

inventory table: remove model, serial, partNum from keys #922

Merged
merged 2 commits into from
Apr 11, 2024

Conversation

LucaNicosia
Copy link
Collaborator

@LucaNicosia LucaNicosia commented Feb 14, 2024

Test inclusion requirements

In case the PR contains an enhancement or a new platform/service support, some tests have to be added for the new functionality:

  • any fix or enhancement SHOULD include relevant new tests or test updates, if any tests need updating.
  • a new platform support MUST include the relevant input files similar to what we have in tests/integration/sqcmds/-input directories, along with the relevant tests in the tests/integration/sqcmds/-samples dir. That list MUST include the all.yml file fully filled out.
  • any new service (or table) addition MUST include comments about what network OS are supported (along with version) with this command along with test samples for those platforms and input files in the *-input dir

For additional information about tests, follow this link

Related Issue

Fixes #

Description

The model, serial and partNum columns should not be keys of the inventory table

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

New Behavior

...

Contrast to Current Behavior

...

Discussion: Benefits and Drawbacks

...

Changes to the Documentation

...

Proposed Release Note Entry

...

Comments

Include additional comments about the this pull request

Double Check

  • I have read the comments and followed the CONTRIBUTING.md.
  • I have explained my PR according to the information in the comments or in a linked issue.
  • My PR source branch is created from the develop branch.
  • My PR targets the develop branch.
  • All my commits have --signoff applied

@LucaNicosia LucaNicosia force-pushed the inventory-remove-model-key branch from cf21d9d to d229d75 Compare February 14, 2024 15:12
@LucaNicosia LucaNicosia changed the title inventory table: remove model key inventory table: remove model, serial, partNum from keys Feb 14, 2024
@ddutt ddutt merged commit 49ee13a into develop Apr 11, 2024
13 checks passed
@ddutt ddutt deleted the inventory-remove-model-key branch April 11, 2024 01:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants