Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: show incompatible plugins for major changes as well #5549

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

lukasholzer
Copy link
Contributor

🎉 Thanks for submitting a pull request! 🎉

Summary

Shows the incompatible plugins log for major version changes as well:

CleanShot 2024-03-14 at 15 21 06

This is a small PR to just unblock the current pain. I'm currently working on a larger refactoring of this area to make it cleaner but this will take more time.

in the meanwhile we can at least see why it did not used the new version


For us to review and ship your PR efficiently, please perform the following steps:

  • Open a bug/issue before writing your code 🧑‍💻. This ensures
    we can discuss the changes and get feedback from everyone that should be involved. If you`re fixing a typo or
    something that`s on fire 🔥 (e.g. incident related), you can skip this step.
  • Read the contribution guidelines 📖. This ensures
    your code follows our style guide and passes our tests.
  • Update or add tests (if any source code was changed or added) 🧪
  • Update or add documentation (if features were changed or added) 📝
  • Make sure the status checks below are successful ✅

A picture of a cute animal (not mandatory, but encouraged)

@lukasholzer lukasholzer self-assigned this Mar 14, 2024
@lukasholzer lukasholzer requested review from a team as code owners March 14, 2024 14:22
@lukasholzer lukasholzer force-pushed the fix/show-incompatible-plugins-for-major-version-as-well branch from cf11bcd to c18589b Compare March 14, 2024 15:03
eduardoboucas
eduardoboucas previously approved these changes Mar 14, 2024
Copy link
Member

@eduardoboucas eduardoboucas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't have the full context, but I trust that you've verified the edge cases.

compatWarning !== '' &&
version !== undefined &&
compatibleVersion !== undefined &&
// Using only the major version prevents printing this warning message when
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this no longer a problem?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sadly this code already dates back my knowledge, but based on the comment I would assume that this "race" condition is super rare.

It might occur still but the worst case in this scenario is that we show a misleading warning in those edge cases.

Where as in the case of the next.js runtime we don't show this warnings as all (as it's a newer major by design).

I think for all new major versions that we release on plugins we still want to show why it did not used the incompatible (new major) version?

@lukasholzer lukasholzer force-pushed the fix/show-incompatible-plugins-for-major-version-as-well branch from e404019 to fe14b28 Compare April 5, 2024 07:33
@lukasholzer lukasholzer requested a review from pieh April 5, 2024 07:34
@github-actions github-actions bot added the stale label Jun 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants