feat: support region configuration option
#5901
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request adds or modifies JavaScript ( |
eduardoboucas
commented
Oct 29, 2024
|
|
||
| const source = ` | ||
| export default async () => new Response("Hello!") | ||
| export const config = { region: 'mars-west-1' }` |
minivan
reviewed
Oct 29, 2024
| 'eu-central-1', | ||
| 'eu-north-1', | ||
| 'eu-south-1', | ||
| 'eu-west-1', |
There was a problem hiding this comment.
does it make sense to include the regions that we don't support in self-serve mode (docs)? The reason we wanted folks to go through Support is to assess whether customers really need these
There was a problem hiding this comment.
Ah, good catch. I copied this list from the UI but didn't realise two of the regions had a boolean set to false. I've removed them in 8546f9c.
There was a problem hiding this comment.
Oops, there's a third one. Fixed in 30be130.
|
minivan
approved these changes
Oct 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds a
regionproperty to the in-source function configuration options.Part of https://linear.app/netlify/issue/RUN-1086/add-region-selection-to-in-source-configuration-options.