update go-sql-driver/mysql to v1.5.0 #63
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… order to support MySQL 8 default auth settings
mraerino
added
the
type: chore
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
in line with netlify/gotrue, in order to support MySQL 8 default auth settings.
- Summary
Wont connect to MySQL 8 databases using the default authentication value, which is now caching_sha2_password. v1.4.0 of this library added support, and while v1.6.0 is also released, I stuck with v1.5.0 because that is the version that https://github.com/netlify/gotrue uses currently.
- Test plan
All tests succeed, db calls run fine.
- Description for the changelog
Update MySQL driver to 1.5.0 to support MySQL 8 default authentication.
- A picture of a cute animal (not mandatory but encouraged)
🐱