Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: LocationFactory and ExcelServiceTrait define the same property (… #23

Merged
merged 1 commit into from
Jun 17, 2024
Merged

fix: LocationFactory and ExcelServiceTrait define the same property (… #23

merged 1 commit into from
Jun 17, 2024

Conversation

saschanowak
Copy link
Member

…$templateSheet) in the composition of LocationFactory

@saschanowak
fix: LocationFactory and ExcelServiceTrait define the same property (…
3add36a 
…$templateSheet) in the composition of LocationFactory
@saschanowak saschanowak requested a review from tweis June 17, 2024 15:05
@github-actions GitHub Actions
Copy link

TYPO3 v12.4 tests on PHP 8.1

Code Coverage
Package Lines Functions Classes Health
netlogix/nxgooglelocations 0.00% 0/555 0.00% 0/78 0.00% 0/14 ❌
Summary 0.00% 0/555 0.00% 0/78 0.00% 0/14 ❌

@github-actions GitHub Actions
Copy link

TYPO3 v12.4 tests on PHP 8.3

Code Coverage
Package Lines Functions Classes Health
netlogix/nxgooglelocations 0.00% 0/555 0.00% 0/78 0.00% 0/14 ❌
Summary 0.00% 0/555 0.00% 0/78 0.00% 0/14 ❌

@github-actions GitHub Actions
Copy link

TYPO3 v12.4 tests on PHP 8.2

Code Coverage
Package Lines Functions Classes Health
netlogix/nxgooglelocations 0.00% 0/555 0.00% 0/78 0.00% 0/14 ❌
Summary 0.00% 0/555 0.00% 0/78 0.00% 0/14 ❌

@tweis tweis merged commit 92da947 into main Jun 17, 2024
3 checks passed
@tweis tweis deleted the bugfix/fatal-error branch June 17, 2024 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tweis tweis tweis approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@saschanowak @tweis