Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump ovn dep for CUDN case #550

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Conversation

jpinsonneau
Copy link
Contributor

Copy link

openshift-ci bot commented Feb 4, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from jpinsonneau. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jpinsonneau
Copy link
Contributor Author

/retest

@jpinsonneau jpinsonneau added the ok-to-test To set manually when a PR is safe to test. Triggers image build on PR. label Feb 4, 2025
Copy link

github-actions bot commented Feb 4, 2025

New images:
quay.io/netobserv/ebpf-bytecode:b1ee0f9
quay.io/netobserv/netobserv-ebpf-agent:b1ee0f9

These will expire after two weeks.

To deploy this build, run from the operator repo, assuming the operator is running:

USER=netobserv VERSION=b1ee0f9 make set-agent-image

@jpinsonneau
Copy link
Contributor Author

image

I'm able to get CUDN using this image and latest ovn version:

launch 4.18,openshift/ovn-kubernetes#2433 gcp,techpreview
NETOBSERV_AGENT_IMAGE=quay.io/netobserv/netobserv-ebpf-agent:b1ee0f9 oc netobserv flows --enable_all --peer_ip=10.0.0.13

Copy link

codecov bot commented Feb 4, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 27.34%. Comparing base (47f7fcf) to head (2fc566c).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #550   +/-   ##
=======================================
  Coverage   27.34%   27.34%           
=======================================
  Files          47       47           
  Lines        4988     4988           
=======================================
  Hits         1364     1364           
  Misses       3521     3521           
  Partials      103      103           
Flag Coverage Δ
unittests 27.34% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@github-actions github-actions bot removed the ok-to-test To set manually when a PR is safe to test. Triggers image build on PR. label Feb 5, 2025
@jpinsonneau jpinsonneau added the ok-to-test To set manually when a PR is safe to test. Triggers image build on PR. label Feb 5, 2025
Copy link

github-actions bot commented Feb 5, 2025

New images:
quay.io/netobserv/ebpf-bytecode:82c244b
quay.io/netobserv/netobserv-ebpf-agent:82c244b

These will expire after two weeks.

To deploy this build, run from the operator repo, assuming the operator is running:

USER=netobserv VERSION=82c244b make set-agent-image

@openshift-ci openshift-ci bot added the lgtm label Feb 5, 2025
Copy link

openshift-ci bot commented Feb 5, 2025

@jpinsonneau: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/qe-e2e-tests a609409 link false /test qe-e2e-tests

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@jpinsonneau
Copy link
Contributor Author

There are still some enrichment issues as discussed in https://redhat-internal.slack.com/archives/C06HPKP6P5Z/p1738759909672689?thread_ts=1730995586.308489&cid=C06HPKP6P5Z

but I think we can merge that for now

@jpinsonneau jpinsonneau added the no-qe This PR doesn't necessitate QE approval label Feb 5, 2025
@jpinsonneau
Copy link
Contributor Author

/retest

@msherif1234
Copy link
Contributor

/lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm no-qe This PR doesn't necessitate QE approval ok-to-test To set manually when a PR is safe to test. Triggers image build on PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants