-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Konflux building frontend only once #718
Konflux building frontend only once #718
Conversation
c0750eb
to
db2e8c0
Compare
- name: CACHI2_ARTIFACT | ||
value: $(tasks.prefetch-dependencies.results.CACHI2_ARTIFACT) | ||
- name: PLATFORM | ||
value: "linux/x86_64" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if you specify the architecture, won't it reject it when trying to build the full image on a different architecture?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
well, looks like it worked 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only the build-container task is run multiple times because of the architecture, this is done by using the matrix definition and running the task for each platform value:
matrix: |
The new build-front-container is only run once, the platform here is just to tell konflux which platform to use to build it once.
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: OlivierCazade The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
dd63c37
into
netobserv:main
Description
Similar to what was done for upstream in #707
Dependencies
n/a
Checklist
If you are not familiar with our processes or don't know what to answer in the list below, let us know in a comment: the maintainers will take care of that.