Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

backport: Building frontend only once (#718) #722

Merged

Conversation

OlivierCazade
Copy link
Collaborator

Description

Building frontend only once to avoid oom errors on arm builds.

Dependencies

n/a

Checklist

If you are not familiar with our processes or don't know what to answer in the list below, let us know in a comment: the maintainers will take care of that.

  • Is this PR backed with a JIRA ticket? If so, make sure it is written as a title prefix (in general, PRs affecting the NetObserv/Network Observability product should be backed with a JIRA ticket - especially if they bring user facing changes).
  • Does this PR require product documentation?
    • If so, make sure the JIRA epic is labelled with "documentation" and provides a description relevant for doc writers, such as use cases or scenarios. Any required step to activate or configure the feature should be documented there, such as new CRD knobs.
  • Does this PR require a product release notes entry?
    • If so, fill in "Release Note Text" in the JIRA.
  • Is there anything else the QE team should know before testing? E.g: configuration changes, environment setup, etc.
    • If so, make sure it is described in the JIRA ticket.
  • QE requirements (check 1 from the list):
    • Standard QE validation, with pre-merge tests unless stated otherwise.
    • Regression tests only (e.g. refactoring with no user-facing change).
    • No QE (e.g. trivial change with high reviewer's confidence, or per agreement with the QE team).

Copy link

codecov bot commented Feb 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.90%. Comparing base (0697e1d) to head (576ffc7).
Report is 1 commits behind head on release-1.8.

Additional details and impacted files
@@             Coverage Diff              @@
##           release-1.8     #722   +/-   ##
============================================
  Coverage        56.90%   56.90%           
============================================
  Files              196      196           
  Lines            10207    10207           
  Branches          1186     1186           
============================================
  Hits              5808     5808           
  Misses            4029     4029           
  Partials           370      370           
Flag Coverage Δ
uitests 59.71% <ø> (ø)
unittests 50.95% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@jotak
Copy link
Member

jotak commented Feb 10, 2025

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Feb 10, 2025
@OlivierCazade
Copy link
Collaborator Author

/approve

Copy link

openshift-ci bot commented Feb 10, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: OlivierCazade

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit a323538 into netobserv:release-1.8 Feb 10, 2025
10 checks passed
OlivierCazade added a commit to OlivierCazade/network-observability-console-plugin that referenced this pull request Feb 13, 2025
OlivierCazade added a commit that referenced this pull request Feb 13, 2025
* Revert "Building frontend only once (#718) (#722)"

This reverts commit a323538.

* Enabling all architectures
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants