SDN-5393: intg netobserv operator with bpfman to manage ebpf programs #829

msherif1234 · 2024-10-29T16:47:07Z

Description

Intg NOO with bpfman to manage ebpf programs life cycle

sample config

agent:
    type: eBPF
    ebpf:      
      privileged: true
      features:
        - "EbpfManager"
      interfaces: ["ens5", "br-ex"]

Dependencies

n/a

Checklist

If you are not familiar with our processes or don't know what to answer in the list below, let us know in a comment: the maintainers will take care of that.

openshift-ci-robot · 2024-10-29T16:47:12Z

codecov · 2024-10-29T18:17:44Z

Codecov Report

Attention: Patch coverage is 6.77291% with 234 lines in your changes missing coverage. Please review.

Project coverage is 62.75%. Comparing base (924e3d2) to head (b83e769).
Report is 2 commits behind head on main.

Files with missing lines	Patch %	Lines
controllers/ebpf/bpfmanager-controller.go	0.00%	190 Missing ⚠️
controllers/ebpf/agent_controller.go	11.36%	34 Missing and 5 partials ⚠️
...lector/v1beta2/flowcollector_validation_webhook.go	0.00%	2 Missing and 1 partial ⚠️
main.go	0.00%	2 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #829      +/-   ##
==========================================
- Coverage   63.93%   62.75%   -1.18%     
==========================================
  Files          76       77       +1     
  Lines       11030    11266     +236     
==========================================
+ Hits         7052     7070      +18     
- Misses       3536     3753     +217     
- Partials      442      443       +1

Flag	Coverage Δ
unittests	`62.75% <6.77%> (-1.18%)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines	Coverage Δ
apis/flowcollector/v1beta1/flowcollector_types.go	`100.00% <ø> (ø)`
apis/flowcollector/v1beta2/flowcollector_types.go	`100.00% <ø> (ø)`
controllers/consoleplugin/consoleplugin_objects.go	`87.52% <100.00%> (ø)`
controllers/flowcollector_controller.go	`73.27% <100.00%> (ø)`
controllers/flp/flp_common_objects.go	`92.07% <100.00%> (ø)`
controllers/flp/flp_controller.go	`64.00% <100.00%> (ø)`
controllers/reconcilers/common.go	`75.00% <100.00%> (ø)`
pkg/helper/flowcollector.go	`82.13% <100.00%> (+0.12%)`	⬆️
pkg/manager/config.go	`0.00% <ø> (ø)`
pkg/manager/manager.go	`58.18% <ø> (ø)`
... and 4 more

... and 4 files with indirect coverage changes

msherif1234 · 2024-10-30T19:43:11Z

/ok-to-test

github-actions · 2024-10-30T19:47:43Z

New images:

quay.io/netobserv/network-observability-operator:22f16c7
quay.io/netobserv/network-observability-operator-bundle:v0.0.0-22f16c7
quay.io/netobserv/network-observability-operator-catalog:v0.0.0-22f16c7

They will expire after two weeks.

To deploy this build:

# Direct deployment, from operator repo
IMAGE=quay.io/netobserv/network-observability-operator:22f16c7 make deploy

# Or using operator-sdk
operator-sdk run bundle quay.io/netobserv/network-observability-operator-bundle:v0.0.0-22f16c7

Or as a Catalog Source:

apiVersion: operators.coreos.com/v1alpha1
kind: CatalogSource
metadata:
  name: netobserv-dev
  namespace: openshift-marketplace
spec:
  sourceType: grpc
  image: quay.io/netobserv/network-observability-operator-catalog:v0.0.0-22f16c7
  displayName: NetObserv development catalog
  publisher: Me
  updateStrategy:
    registryPoll:
      interval: 1m

msherif1234 · 2024-10-30T20:41:24Z

/ok-to-test

github-actions · 2024-10-30T20:45:41Z

New images:

quay.io/netobserv/network-observability-operator:4fddf88
quay.io/netobserv/network-observability-operator-bundle:v0.0.0-4fddf88
quay.io/netobserv/network-observability-operator-catalog:v0.0.0-4fddf88

They will expire after two weeks.

To deploy this build:

# Direct deployment, from operator repo
IMAGE=quay.io/netobserv/network-observability-operator:4fddf88 make deploy

# Or using operator-sdk
operator-sdk run bundle quay.io/netobserv/network-observability-operator-bundle:v0.0.0-4fddf88

Or as a Catalog Source:

apiVersion: operators.coreos.com/v1alpha1
kind: CatalogSource
metadata:
  name: netobserv-dev
  namespace: openshift-marketplace
spec:
  sourceType: grpc
  image: quay.io/netobserv/network-observability-operator-catalog:v0.0.0-4fddf88
  displayName: NetObserv development catalog
  publisher: Me
  updateStrategy:
    registryPoll:
      interval: 1m

msherif1234 · 2024-10-30T21:13:08Z

/ok-to-test

github-actions · 2024-10-30T21:17:07Z

New images:

quay.io/netobserv/network-observability-operator:e758c5c
quay.io/netobserv/network-observability-operator-bundle:v0.0.0-e758c5c
quay.io/netobserv/network-observability-operator-catalog:v0.0.0-e758c5c

They will expire after two weeks.

To deploy this build:

# Direct deployment, from operator repo
IMAGE=quay.io/netobserv/network-observability-operator:e758c5c make deploy

# Or using operator-sdk
operator-sdk run bundle quay.io/netobserv/network-observability-operator-bundle:v0.0.0-e758c5c

Or as a Catalog Source:

apiVersion: operators.coreos.com/v1alpha1
kind: CatalogSource
metadata:
  name: netobserv-dev
  namespace: openshift-marketplace
spec:
  sourceType: grpc
  image: quay.io/netobserv/network-observability-operator-catalog:v0.0.0-e758c5c
  displayName: NetObserv development catalog
  publisher: Me
  updateStrategy:
    registryPoll:
      interval: 1m

msherif1234 · 2024-10-30T21:25:02Z

/ok-to-test

github-actions · 2024-10-30T21:28:50Z

New images:

quay.io/netobserv/network-observability-operator:05a05ba
quay.io/netobserv/network-observability-operator-bundle:v0.0.0-05a05ba
quay.io/netobserv/network-observability-operator-catalog:v0.0.0-05a05ba

They will expire after two weeks.

To deploy this build:

# Direct deployment, from operator repo
IMAGE=quay.io/netobserv/network-observability-operator:05a05ba make deploy

# Or using operator-sdk
operator-sdk run bundle quay.io/netobserv/network-observability-operator-bundle:v0.0.0-05a05ba

Or as a Catalog Source:

apiVersion: operators.coreos.com/v1alpha1
kind: CatalogSource
metadata:
  name: netobserv-dev
  namespace: openshift-marketplace
spec:
  sourceType: grpc
  image: quay.io/netobserv/network-observability-operator-catalog:v0.0.0-05a05ba
  displayName: NetObserv development catalog
  publisher: Me
  updateStrategy:
    registryPoll:
      interval: 1m

openshift-ci-robot · 2024-10-30T21:52:16Z

jotak · 2024-12-11T14:15:27Z

controllers/ebpf/agent_controller.go

@@ -355,6 +376,32 @@ func (c *AgentController) desired(ctx context.Context, coll *flowslatest.FlowCol

 	}

+	if helper.IsAgentFeatureEnabled(&coll.Spec.Agent.EBPF, flowslatest.EbpfManager) {
+		if !coll.Spec.Agent.EBPF.Privileged {
+			rlog.Error(fmt.Errorf("invalid configuration"), "To enable BPF Manager feature privileged mode needs to be enabled")


this error/warning should also be added to the webhook: same as here https://github.com/netobserv/network-observability-operator/blob/main/apis/flowcollector/v1beta2/flowcollector_validation_webhook.go#L101-L103

jotak · 2024-12-11T14:20:20Z

controllers/ebpf/bpfmanager-controller.go

+
+const (
+	netobservApp     = "netobserv"
+	netobservBCImage = "quay.io/netobserv/ebpf-bytecode:latest"


can you make that picked up from the command line argument, same as the other images (cf in main.go flag.StringVar(&config.EBPFAgentImage, "ebpf-agent-image", "quay.io/netobserv/netobserv-ebpf-agent:main", "The image of the eBPF agent")

msherif1234 · 2024-12-11T15:53:42Z

/ok-to-test

github-actions · 2024-12-11T15:57:40Z

New images:

quay.io/netobserv/network-observability-operator:37f3a03
quay.io/netobserv/network-observability-operator-bundle:v0.0.0-37f3a03
quay.io/netobserv/network-observability-operator-catalog:v0.0.0-37f3a03

They will expire after two weeks.

To deploy this build:

# Direct deployment, from operator repo
IMAGE=quay.io/netobserv/network-observability-operator:37f3a03 make deploy

# Or using operator-sdk
operator-sdk run bundle quay.io/netobserv/network-observability-operator-bundle:v0.0.0-37f3a03

Or as a Catalog Source:

apiVersion: operators.coreos.com/v1alpha1
kind: CatalogSource
metadata:
  name: netobserv-dev
  namespace: openshift-marketplace
spec:
  sourceType: grpc
  image: quay.io/netobserv/network-observability-operator-catalog:v0.0.0-37f3a03
  displayName: NetObserv development catalog
  publisher: Me
  updateStrategy:
    registryPoll:
      interval: 1m

jotak

thanks @msherif1234 , lgtm

msherif1234 · 2024-12-12T19:38:58Z

/ok-to-test

github-actions · 2024-12-12T19:43:03Z

New images:

quay.io/netobserv/network-observability-operator:9d79f9e
quay.io/netobserv/network-observability-operator-bundle:v0.0.0-9d79f9e
quay.io/netobserv/network-observability-operator-catalog:v0.0.0-9d79f9e

They will expire after two weeks.

To deploy this build:

# Direct deployment, from operator repo
IMAGE=quay.io/netobserv/network-observability-operator:9d79f9e make deploy

# Or using operator-sdk
operator-sdk run bundle quay.io/netobserv/network-observability-operator-bundle:v0.0.0-9d79f9e

Or as a Catalog Source:

apiVersion: operators.coreos.com/v1alpha1
kind: CatalogSource
metadata:
  name: netobserv-dev
  namespace: openshift-marketplace
spec:
  sourceType: grpc
  image: quay.io/netobserv/network-observability-operator-catalog:v0.0.0-9d79f9e
  displayName: NetObserv development catalog
  publisher: Me
  updateStrategy:
    registryPoll:
      interval: 1m

openshift-ci · 2024-12-12T22:16:14Z

@msherif1234: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-operator	`a3ddea4`	link	false	`/test e2e-operator`

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Signed-off-by: Mohamed Mahmoud <[email protected]>

jotak · 2024-12-13T14:06:05Z

/lgtm

msherif1234 · 2024-12-13T14:08:10Z

/approve

openshift-ci · 2024-12-13T14:08:17Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: msherif1234

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [msherif1234]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci-robot added the jira/valid-reference label Oct 29, 2024

msherif1234 changed the title ~~SDN-5393: intg netobserv operator with bpfman to manage ebpf programs~~ WIP: SDN-5393: intg netobserv operator with bpfman to manage ebpf programs Oct 29, 2024

openshift-ci bot added the do-not-merge/work-in-progress label Oct 29, 2024

msherif1234 mentioned this pull request Oct 29, 2024

SDN-5393: eBPF agent intg with bpfman for ebpf progs life cycle mgmts netobserv/netobserv-ebpf-agent#443

Merged

11 tasks

msherif1234 force-pushed the bpfman-intg branch 2 times, most recently from 29003ea to b6ab8b9 Compare October 29, 2024 17:32

msherif1234 marked this pull request as draft October 30, 2024 12:58

openshift-ci bot added the ok-to-test To set manually when a PR is safe to test. Triggers image build on PR. label Oct 30, 2024

msherif1234 force-pushed the bpfman-intg branch from b6ab8b9 to b90a303 Compare October 30, 2024 20:41

github-actions bot removed the ok-to-test To set manually when a PR is safe to test. Triggers image build on PR. label Oct 30, 2024

openshift-ci bot added the ok-to-test To set manually when a PR is safe to test. Triggers image build on PR. label Oct 30, 2024

msherif1234 force-pushed the bpfman-intg branch from b90a303 to 210c2f9 Compare October 30, 2024 21:12

github-actions bot removed the ok-to-test To set manually when a PR is safe to test. Triggers image build on PR. label Oct 30, 2024

openshift-ci bot added the ok-to-test To set manually when a PR is safe to test. Triggers image build on PR. label Oct 30, 2024

msherif1234 force-pushed the bpfman-intg branch from 210c2f9 to 0700400 Compare October 30, 2024 21:24

github-actions bot removed the ok-to-test To set manually when a PR is safe to test. Triggers image build on PR. label Oct 30, 2024

openshift-ci bot added the ok-to-test To set manually when a PR is safe to test. Triggers image build on PR. label Oct 30, 2024

msherif1234 force-pushed the bpfman-intg branch from 0700400 to fb59fa9 Compare October 30, 2024 22:07

github-actions bot removed the ok-to-test To set manually when a PR is safe to test. Triggers image build on PR. label Oct 30, 2024

msherif1234 force-pushed the bpfman-intg branch from 326ed14 to 42caf46 Compare December 9, 2024 17:28

jotak reviewed Dec 11, 2024

View reviewed changes

msherif1234 requested a review from jotak December 11, 2024 15:36

msherif1234 force-pushed the bpfman-intg branch from 0bf61af to b83e769 Compare December 11, 2024 15:47

openshift-ci bot added the ok-to-test To set manually when a PR is safe to test. Triggers image build on PR. label Dec 11, 2024

jotak approved these changes Dec 11, 2024

View reviewed changes

openshift-ci bot assigned jotak Dec 11, 2024

openshift-ci bot added lgtm and removed lgtm labels Dec 11, 2024

github-actions bot removed the ok-to-test To set manually when a PR is safe to test. Triggers image build on PR. label Dec 12, 2024

openshift-ci bot added the ok-to-test To set manually when a PR is safe to test. Triggers image build on PR. label Dec 12, 2024

msherif1234 force-pushed the bpfman-intg branch from 6c2bc18 to a3ddea4 Compare December 12, 2024 21:10

github-actions bot removed the ok-to-test To set manually when a PR is safe to test. Triggers image build on PR. label Dec 12, 2024

msherif1234 added 3 commits December 13, 2024 09:03

SDN-5393: intg netobserv operator with bpfman to manage ebpf programs

9d6abf7

Signed-off-by: Mohamed Mahmoud <[email protected]>

Add Bytecode image to config package

0f9c043

Signed-off-by: Mohamed Mahmoud <[email protected]>

Add additional flow metrics map

3c79658

Signed-off-by: Mohamed Mahmoud <[email protected]>

msherif1234 force-pushed the bpfman-intg branch from a3ddea4 to 3c79658 Compare December 13, 2024 14:03

openshift-ci bot added the lgtm label Dec 13, 2024

openshift-ci bot added the approved label Dec 13, 2024

msherif1234 merged commit 5ba1b46 into netobserv:main Dec 13, 2024
7 of 11 checks passed

msherif1234 deleted the bpfman-intg branch December 13, 2024 14:36

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

SDN-5393: intg netobserv operator with bpfman to manage ebpf programs #829

SDN-5393: intg netobserv operator with bpfman to manage ebpf programs #829

msherif1234 commented Oct 29, 2024 •

edited

Loading

openshift-ci-robot commented Oct 29, 2024 •

edited by openshift-ci bot

Loading

Description

Dependencies

Checklist

codecov bot commented Oct 29, 2024 •

edited

Loading

msherif1234 commented Oct 30, 2024

github-actions bot commented Oct 30, 2024

msherif1234 commented Oct 30, 2024

github-actions bot commented Oct 30, 2024

msherif1234 commented Oct 30, 2024

github-actions bot commented Oct 30, 2024

msherif1234 commented Oct 30, 2024

github-actions bot commented Oct 30, 2024

openshift-ci-robot commented Oct 30, 2024 •

edited by openshift-ci bot

Loading

Description

Dependencies

Checklist

jotak Dec 11, 2024

jotak Dec 11, 2024

msherif1234 commented Dec 11, 2024

github-actions bot commented Dec 11, 2024

jotak left a comment

msherif1234 commented Dec 12, 2024

github-actions bot commented Dec 12, 2024

openshift-ci bot commented Dec 12, 2024

jotak commented Dec 13, 2024

msherif1234 commented Dec 13, 2024

openshift-ci bot commented Dec 13, 2024

SDN-5393: intg netobserv operator with bpfman to manage ebpf programs #829

SDN-5393: intg netobserv operator with bpfman to manage ebpf programs #829

Conversation

msherif1234 commented Oct 29, 2024 • edited Loading

Description

Dependencies

Checklist

openshift-ci-robot commented Oct 29, 2024 • edited by openshift-ci bot Loading

Description

Dependencies

Checklist

codecov bot commented Oct 29, 2024 • edited Loading

Codecov Report

msherif1234 commented Oct 30, 2024

github-actions bot commented Oct 30, 2024

msherif1234 commented Oct 30, 2024

github-actions bot commented Oct 30, 2024

msherif1234 commented Oct 30, 2024

github-actions bot commented Oct 30, 2024

msherif1234 commented Oct 30, 2024

github-actions bot commented Oct 30, 2024

openshift-ci-robot commented Oct 30, 2024 • edited by openshift-ci bot Loading

Description

Dependencies

Checklist

jotak Dec 11, 2024

Choose a reason for hiding this comment

jotak Dec 11, 2024

Choose a reason for hiding this comment

msherif1234 commented Dec 11, 2024

github-actions bot commented Dec 11, 2024

jotak left a comment

Choose a reason for hiding this comment

msherif1234 commented Dec 12, 2024

github-actions bot commented Dec 12, 2024

openshift-ci bot commented Dec 12, 2024

jotak commented Dec 13, 2024

msherif1234 commented Dec 13, 2024

openshift-ci bot commented Dec 13, 2024

msherif1234 commented Oct 29, 2024 •

edited

Loading

openshift-ci-robot commented Oct 29, 2024 •

edited by openshift-ci bot

Loading

codecov bot commented Oct 29, 2024 •

edited

Loading

openshift-ci-robot commented Oct 30, 2024 •

edited by openshift-ci bot

Loading