-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature] Add detailed final RPM output #67
base: main
Are you sure you want to change the base?
Conversation
I wonder whether this is not also a good opportunity to report the corresponding durations for the different RPM values?
That would give a concise yet pretty complete detailed report? Moving the stats measure to the front would help in visually finding corresponding lines quicker (at least for me). |
From the Slack channel, there is some additional description from @moeller0 that I will take into account: Maybe add the respective time unit?
or
And, for
Note the delay numbers are likely wrong... just take this as example... |
@moeller0 Sorry for the late response. I have added additional detailed output -- what you suggested makes the output that much more complete! I am not sure that I matched your suggested formatting. Please let me know what changes you think would be helpful. One big piece that I did add: The detailed RPM calculation information in the directions. I have no idea why I did not add that before. It's there now and I think that makes the output that much better. Thank you for the suggestion! |
@moeller0 I have updated this branch to produce a slightly more verbose output for trimmed measurements:
Let me know if that looks okay to you! |
b5fd2c7
to
3fa054c
Compare
Calculate and display additional RPM information when the user requests with the `--detailed` CLI flag. Signed-off-by: Will Hawkins <[email protected]>
Add additional detailed output.
Add additional context for trimmed measurements count.
Print out some additional information in detailed mode.
3fa054c
to
2483f88
Compare
Remove duplicate output.
Calculate and display additional RPM information when the user requests with the
--detailed
CLI flag.