Add MTU property as parameter of the Service #107
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
10 tasks
Makes the MTU configurable in addition to the vlan ID and the base interface. Signed-off-by: Lionel Jouin <[email protected]>
ljkiraly
added a commit
to Nordix/nsm-sdk-vpp
that referenced
this pull request
Nov 10, 2022
The MTU should be updated in connection context based on the host interface MTU in vpp instead of the sub-interface MTU. Related PR: networkservicemesh/cmd-nse-remote-vlan/pull/107 Signed-off-by: Laszlo Kiraly <[email protected]>
ljkiraly
added a commit
to Nordix/nsm-sdk-vpp
that referenced
this pull request
Nov 14, 2022
The MTU should be updated in connection context based on the host interface MTU in vpp instead of the sub-interface MTU. Related PR: networkservicemesh/cmd-nse-remote-vlan/pull/107 Signed-off-by: Laszlo Kiraly <[email protected]>
ljkiraly
added a commit
to Nordix/nsm-sdk-vpp
that referenced
this pull request
Nov 19, 2022
The MTU should be updated in connection context based on the host interface MTU in vpp instead of the sub-interface MTU. Related PR: networkservicemesh/cmd-nse-remote-vlan/pull/107 Signed-off-by: Laszlo Kiraly <[email protected]>
edwarnicke
pushed a commit
to networkservicemesh/sdk-vpp
that referenced
this pull request
Nov 19, 2022
The MTU should be updated in connection context based on the host interface MTU in vpp instead of the sub-interface MTU. Related PR: networkservicemesh/cmd-nse-remote-vlan/pull/107 Signed-off-by: Laszlo Kiraly <[email protected]> Signed-off-by: Laszlo Kiraly <[email protected]>
nsmbot
pushed a commit
to networkservicemesh/cmd-nsc-vpp
that referenced
this pull request
Nov 19, 2022
…k-vpp@main PR link: networkservicemesh/sdk-vpp#656 Commit: 89baf2c Author: Laszlo Kiraly Date: 2022-11-19 19:14:53 +0100 Message: - Fix MTU adjustment in case of remote vlan mechanism (#656) The MTU should be updated in connection context based on the host interface MTU in vpp instead of the sub-interface MTU. Related PR: networkservicemesh/cmd-nse-remote-vlan/pull/107 Signed-off-by: Laszlo Kiraly <[email protected]> Signed-off-by: NSMBot <[email protected]>
nsmbot
pushed a commit
to networkservicemesh/cmd-nse-firewall-vpp
that referenced
this pull request
Nov 19, 2022
…k-vpp@main PR link: networkservicemesh/sdk-vpp#656 Commit: 89baf2c Author: Laszlo Kiraly Date: 2022-11-19 19:14:53 +0100 Message: - Fix MTU adjustment in case of remote vlan mechanism (#656) The MTU should be updated in connection context based on the host interface MTU in vpp instead of the sub-interface MTU. Related PR: networkservicemesh/cmd-nse-remote-vlan/pull/107 Signed-off-by: Laszlo Kiraly <[email protected]> Signed-off-by: NSMBot <[email protected]>
nsmbot
pushed a commit
to networkservicemesh/cmd-nse-icmp-responder-vpp
that referenced
this pull request
Nov 19, 2022
…k-vpp@main PR link: networkservicemesh/sdk-vpp#656 Commit: 89baf2c Author: Laszlo Kiraly Date: 2022-11-19 19:14:53 +0100 Message: - Fix MTU adjustment in case of remote vlan mechanism (#656) The MTU should be updated in connection context based on the host interface MTU in vpp instead of the sub-interface MTU. Related PR: networkservicemesh/cmd-nse-remote-vlan/pull/107 Signed-off-by: Laszlo Kiraly <[email protected]> Signed-off-by: NSMBot <[email protected]>
nsmbot
pushed a commit
to networkservicemesh/cmd-nse-simple-vl3-docker
that referenced
this pull request
Nov 19, 2022
…k-vpp@main PR link: networkservicemesh/sdk-vpp#656 Commit: 89baf2c Author: Laszlo Kiraly Date: 2022-11-19 19:14:53 +0100 Message: - Fix MTU adjustment in case of remote vlan mechanism (#656) The MTU should be updated in connection context based on the host interface MTU in vpp instead of the sub-interface MTU. Related PR: networkservicemesh/cmd-nse-remote-vlan/pull/107 Signed-off-by: Laszlo Kiraly <[email protected]> Signed-off-by: NSMBot <[email protected]>
nsmbot
pushed a commit
to networkservicemesh/cmd-nse-vlan-vpp
that referenced
this pull request
Nov 19, 2022
…k-vpp@main PR link: networkservicemesh/sdk-vpp#656 Commit: 89baf2c Author: Laszlo Kiraly Date: 2022-11-19 19:14:53 +0100 Message: - Fix MTU adjustment in case of remote vlan mechanism (#656) The MTU should be updated in connection context based on the host interface MTU in vpp instead of the sub-interface MTU. Related PR: networkservicemesh/cmd-nse-remote-vlan/pull/107 Signed-off-by: Laszlo Kiraly <[email protected]> Signed-off-by: NSMBot <[email protected]>
nsmbot
pushed a commit
to networkservicemesh/cmd-forwarder-vpp
that referenced
this pull request
Nov 19, 2022
…k-vpp@main PR link: networkservicemesh/sdk-vpp#656 Commit: 89baf2c Author: Laszlo Kiraly Date: 2022-11-19 19:14:53 +0100 Message: - Fix MTU adjustment in case of remote vlan mechanism (#656) The MTU should be updated in connection context based on the host interface MTU in vpp instead of the sub-interface MTU. Related PR: networkservicemesh/cmd-nse-remote-vlan/pull/107 Signed-off-by: Laszlo Kiraly <[email protected]> Signed-off-by: NSMBot <[email protected]>
nsmbot
pushed a commit
to networkservicemesh/cmd-nsc-simple-docker
that referenced
this pull request
Nov 19, 2022
…k-vpp@main PR link: networkservicemesh/sdk-vpp#656 Commit: 89baf2c Author: Laszlo Kiraly Date: 2022-11-19 19:14:53 +0100 Message: - Fix MTU adjustment in case of remote vlan mechanism (#656) The MTU should be updated in connection context based on the host interface MTU in vpp instead of the sub-interface MTU. Related PR: networkservicemesh/cmd-nse-remote-vlan/pull/107 Signed-off-by: Laszlo Kiraly <[email protected]> Signed-off-by: NSMBot <[email protected]>
nsmbot
pushed a commit
to networkservicemesh/cmd-nse-vl3-vpp
that referenced
this pull request
Nov 19, 2022
…k-vpp@main PR link: networkservicemesh/sdk-vpp#656 Commit: 89baf2c Author: Laszlo Kiraly Date: 2022-11-19 19:14:53 +0100 Message: - Fix MTU adjustment in case of remote vlan mechanism (#656) The MTU should be updated in connection context based on the host interface MTU in vpp instead of the sub-interface MTU. Related PR: networkservicemesh/cmd-nse-remote-vlan/pull/107 Signed-off-by: Laszlo Kiraly <[email protected]> Signed-off-by: NSMBot <[email protected]>
This was referenced Nov 19, 2022
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes the MTU configurable in addition to the vlan ID and the base interface.
Changes in the SDK-VPP is needed to support this change since the vlan-mtu chain element will overwrite the MTU if the MTU of the base interface is lower than the requested one. Currently the base interface always has 0 as MTU.
https://github.com/networkservicemesh/sdk-vpp/blob/main/pkg/networkservice/mechanisms/vlan/mtu/client.go#L74