Export constants from token package

[mardim91]

Signed-off-by: Dimitrios Markou [email protected]

[edwarnicke]

@mardim91 I presume this is for your webhook work, correct?

If so, are the constants the only dependencies you'd be pulling into the webhook repo? I ask, because minimizing dependencies is always on my mind, and I'm curious is there is a way to do so here :)

[mardim91]

@mardim91 I presume this is for your webhook work, correct?

If so, are the constants the only dependencies you'd be pulling into the webhook repo? I ask, because minimizing dependencies is always on my mind, and I'm curious is there is a way to do so here :)

@edwarnicke yes you are right the constatns from sdk-sriov repo is my only dependency. I agree maybe we should try to minimize the dependencies. We can just create those constants in some folder inside the webhook repo but this seems like duplicate code for the same constants or maybe we can have like a policy to put all the constants of NSM universe in a single repo and all the projects can use that repo to import constants. One candidate repo for that could be nsm/api. What do you think ?

[edwarnicke]

Yeah... I share your concern about defining constants in multiple places... its asking for a bug later on when things are renamed.

For many constants, we put them in the api repo if they are shared across different downstream repos. Would that make sense here? If so, where would it make sense to put it in the api repo? Does the webhook currently depend on the API repo?

Like so many other things in code... this is going to be a game of trade-offs... so lets talk about the options and see what looks like the best among them :)

[mardim91]

Right now webhook only depends on the sdk repo. In case that we decide that api repo is the right place from strategic perspective to gather all the NSM constants then we can make it a dependency to webhook repo. Regarding where to put the constants that I do not know yet but definetely makes sense to me to put the constants for sriov token to the api repo.

[edwarnicke]

Right now webhook only depends on the sdk repo. In case that we decide that api repo is the right place from strategic perspective to gather all the NSM constants then we can make it a dependency to webhook repo. Regarding where to put the constants that I do not know yet but definetely makes sense to me to put the constants for sriov token to the api repo.

If the webhook depends on the sdk repo, it depends transitively on the api repo too :)

@Bolodya1997 - thoughts on the proper place to put this constant in the api repo?

[edwarnicke]

@mardim91 Would it make sense to put SriovTokenLabel in `/pkg/api/networkservice/labels/sriov/constants.go' in https://github.com/networkservicemesh/api/

[mardim91]

@mardim91 Would it make sense to put SriovTokenLabel in `/pkg/api/networkservice/labels/sriov/constants.go' in https://github.com/networkservicemesh/api/

@edwarnicke yes ok I will do that. I guess we should abandon this PR right ?

[edwarnicke]

@edwarnicke yes ok I will do that. I guess we should abandon this PR right ?

@mardim91 Feel free to Close it and submit the PR to API :)