Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: manage corner cases of the begin chain element #1648

Closed
wants to merge 25 commits into from

Conversation

denis-tingaikin
Copy link
Member

Description

Issue link

networkservicemesh/cmd-forwarder-vpp#1134

How Has This Been Tested?

  • Added unit testing to cover
  • Tested manually
  • Tested by integration testing
  • Have not tested

Types of changes

  • Bug fix
  • New functionality
  • Documentation
  • Refactoring
  • CI

denis-tingaikin and others added 25 commits July 29, 2024 12:19
Signed-off-by: Denis Tingaikin <[email protected]>
Signed-off-by: NikitaSkrynnik <[email protected]>
Signed-off-by: NikitaSkrynnik <[email protected]>
Signed-off-by: NikitaSkrynnik <[email protected]>
Signed-off-by: NikitaSkrynnik <[email protected]>
Signed-off-by: NikitaSkrynnik <[email protected]>
Signed-off-by: NikitaSkrynnik <[email protected]>
Signed-off-by: NikitaSkrynnik <[email protected]>
* Revert "Add peer cleanup on Requests and Closes from begin (#1636)"

This reverts commit c01f9e1.

* Revert "fix authorize (#1637)"

This reverts commit 50c0908.

* fix ci issue

Signed-off-by: denis-tingaikin <[email protected]>

---------

Signed-off-by: denis-tingaikin <[email protected]>
Signed-off-by: NikitaSkrynnik <[email protected]>
* use network service for generating iface name on nse side

Signed-off-by: denis-tingaikin <[email protected]>

* update alphabet

Signed-off-by: denis-tingaikin <[email protected]>

* fix tests

Signed-off-by: denis-tingaikin <[email protected]>

---------

Signed-off-by: denis-tingaikin <[email protected]>
Signed-off-by: NikitaSkrynnik <[email protected]>
* fix 'Segmentation violation in nsmgr'

Signed-off-by: denis-tingaikin <[email protected]>

* add unit test to cover issue

Signed-off-by: denis-tingaikin <[email protected]>

* Fix linter issue

Signed-off-by: denis-tingaikin <[email protected]>

---------

Signed-off-by: denis-tingaikin <[email protected]>
Signed-off-by: NikitaSkrynnik <[email protected]>
* fix linter

Signed-off-by: denis-tingaikin <[email protected]>

* fix ci issues

Signed-off-by: denis-tingaikin <[email protected]>

* fix tests

Signed-off-by: denis-tingaikin <[email protected]>

---------

Signed-off-by: denis-tingaikin <[email protected]>
Signed-off-by: NikitaSkrynnik <[email protected]>
This reverts commit bf440a3.

Signed-off-by: NikitaSkrynnik <[email protected]>
Signed-off-by: denis-tingaikin <[email protected]>
Signed-off-by: NikitaSkrynnik <[email protected]>
Signed-off-by: denis-tingaikin <[email protected]>
Signed-off-by: NikitaSkrynnik <[email protected]>
Signed-off-by: NikitaSkrynnik <[email protected]>
Signed-off-by: NikitaSkrynnik <[email protected]>
Signed-off-by: NikitaSkrynnik <[email protected]>
Signed-off-by: NikitaSkrynnik <[email protected]>
Signed-off-by: NikitaSkrynnik <[email protected]>
Signed-off-by: NikitaSkrynnik <[email protected]>
Signed-off-by: NikitaSkrynnik <[email protected]>
Signed-off-by: NikitaSkrynnik <[email protected]>
Signed-off-by: NikitaSkrynnik <[email protected]>
@NikitaSkrynnik
Copy link
Contributor

Seems like done in another PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants