Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a timeout for Closes in begin.Server #1650

Merged
merged 15 commits into from
Aug 8, 2024
Merged

Add a timeout for Closes in begin.Server #1650

merged 15 commits into from
Aug 8, 2024

Conversation

NikitaSkrynnik
Copy link
Contributor

@NikitaSkrynnik NikitaSkrynnik commented Jul 26, 2024 •
edited
Loading

Description

Use a context with bigger timeout in begin.Close to avoid leaking interfaces. This PR fixes all problems with leaking vpp interfaces on forwarder described in issues below.

Issue link

#1649
networkservicemesh/cmd-forwarder-vpp#1120
networkservicemesh/cmd-forwarder-vpp#1129

How Has This Been Tested?

  • Added unit testing to cover
  • Tested manually
  • Tested by integration testing
  • Have not tested

Types of changes

  • Bug fix
  • New functionality
  • Documentation
  • Refactoring
  • CI

@NikitaSkrynnik NikitaSkrynnik force-pushed the add-begin-select branch 3 times, most recently from e567dae to 1586d35 Compare July 28, 2024 23:28
@NikitaSkrynnik NikitaSkrynnik changed the base branch from add-begin-select to main July 28, 2024 23:29
@NikitaSkrynnik NikitaSkrynnik force-pushed the add-begin-select branch 7 times, most recently from 9e57955 to 515e6bc Compare July 29, 2024 01:19
@NikitaSkrynnik NikitaSkrynnik mentioned this pull request Aug 6, 2024
Closed
denis-tingaikin and others added 9 commits August 7, 2024 10:38
@denis-tingaikin @NikitaSkrynnik
fix corner cases of the begin chain element
5141e68 
Signed-off-by: denis-tingaikin <[email protected]>
Signed-off-by: NikitaSkrynnik <[email protected]>
@denis-tingaikin @NikitaSkrynnik
disable Test_RestartDuringRefresh
041fb14 
Signed-off-by: denis-tingaikin <[email protected]>
Signed-off-by: NikitaSkrynnik <[email protected]>
@NikitaSkrynnik
add fresh context
30be3fe 
Signed-off-by: NikitaSkrynnik <[email protected]>
@NikitaSkrynnik
add extended context
d2a87ce 
Signed-off-by: NikitaSkrynnik <[email protected]>
@NikitaSkrynnik
add refreshed close context everywhere in begin
ae26303 
Signed-off-by: NikitaSkrynnik <[email protected]>
@NikitaSkrynnik
fix some unit tests
1f9d7b8 
Signed-off-by: NikitaSkrynnik <[email protected]>
@NikitaSkrynnik
unskip some tests
b094444 
Signed-off-by: NikitaSkrynnik <[email protected]>
@NikitaSkrynnik
fix golang linter issues
73d57e9 
Signed-off-by: NikitaSkrynnik <[email protected]>
@NikitaSkrynnik
debug
4245153 
Signed-off-by: NikitaSkrynnik <[email protected]>
@NikitaSkrynnik
cleanup
5f5242b 
Signed-off-by: NikitaSkrynnik <[email protected]>
@NikitaSkrynnik
fix race condition
cbbb857 
Signed-off-by: NikitaSkrynnik <[email protected]>
@NikitaSkrynnik NikitaSkrynnik marked this pull request as ready for review August 7, 2024 00:48
denis-tingaikin
denis-tingaikin approved these changes Aug 7, 2024
View reviewed changes
Copy link
Member

@denis-tingaikin denis-tingaikin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we cover new code branches with unit tests?

nsmbot pushed a commit to networkservicemesh/deployments-k8s that referenced this pull request Aug 8, 2024
Update go.mod and go.sum to latest version from networkservicemesh/cm…
0e6232c 
…d-nsc@main

PR link: networkservicemesh/cmd-nsc#640

Commit: 70af2ee
Author: Network Service Mesh Bot
Date: 2024-08-08 05:14:23 -0500
Message:
  - Update go.mod and go.sum to latest version from networkservicemesh/sdk-sriov@main (#640)
PR link: networkservicemesh/sdk-sriov#602
Commit: 8252927
Author: Network Service Mesh Bot
Date: 2024-08-08 05:11:19 -0500
Message:
    - Update go.mod and go.sum to latest version from networkservicemesh/sdk-kernel@main (#602)
PR link: networkservicemesh/sdk-kernel#671
Commit: c7b682d
Author: Network Service Mesh Bot
Date: 2024-08-08 05:06:17 -0500
Message:
        - Update go.mod and go.sum to latest version from networkservicemesh/sdk@main (#671)
PR link: networkservicemesh/sdk#1650
Commit: 3016313
Author: Nikita Skrynnik
Date: 2024-08-08 21:03:55 +1100
Message:
                - Add a timeout for Closes in begin.Server (#1650)
* fix corner cases of the begin chain element
* disable Test_RestartDuringRefresh
* add fresh context
* add extended context
* add refreshed close context everywhere in begin
* fix some unit tests
* unskip some tests
* fix golang linter issues
* debug
* cleanup
* fix race condition
* add unit tests
* fix go linter issues
* fix race conditiong
* apply review comments
---------
Signed-off-by: denis-tingaikin <[email protected]>
Signed-off-by: NikitaSkrynnik <[email protected]>
Signed-off-by: NSMBot <[email protected]>
nsmbot added a commit to networkservicemesh/cmd-nsc-init that referenced this pull request Aug 8, 2024
@nsmbot
Update go.mod and go.sum to latest version from networkservicemesh/sd…
fa3cbbf 
…k-sriov@main (#764)

PR link: networkservicemesh/sdk-sriov#602

Commit: 8252927
Author: Network Service Mesh Bot
Date: 2024-08-08 05:11:19 -0500
Message:
  - Update go.mod and go.sum to latest version from networkservicemesh/sdk-kernel@main (#602)
PR link: networkservicemesh/sdk-kernel#671
Commit: c7b682d
Author: Network Service Mesh Bot
Date: 2024-08-08 05:06:17 -0500
Message:
    - Update go.mod and go.sum to latest version from networkservicemesh/sdk@main (#671)
PR link: networkservicemesh/sdk#1650
Commit: 3016313
Author: Nikita Skrynnik
Date: 2024-08-08 21:03:55 +1100
Message:
        - Add a timeout for Closes in begin.Server (#1650)
* fix corner cases of the begin chain element
* disable Test_RestartDuringRefresh
* add fresh context
* add extended context
* add refreshed close context everywhere in begin
* fix some unit tests
* unskip some tests
* fix golang linter issues
* debug
* cleanup
* fix race condition
* add unit tests
* fix go linter issues
* fix race conditiong
* apply review comments
---------

Signed-off-by: denis-tingaikin <[email protected]>
Signed-off-by: NikitaSkrynnik <[email protected]>
Signed-off-by: NSMBot <[email protected]>
Co-authored-by: NSMBot <[email protected]>
nsmbot added a commit to networkservicemesh/deployments-k8s that referenced this pull request Aug 8, 2024
@nsmbot
Update go.mod and go.sum to latest version from networkservicemesh/cm…
3a2969b 
…d-nsc-vpp@main (#12147)

PR link: networkservicemesh/cmd-nsc-vpp#704

Commit: b0756ba
Author: Network Service Mesh Bot
Date: 2024-08-08 05:13:13 -0500
Message:
  - Update go.mod and go.sum to latest version from networkservicemesh/sdk-vpp@main (#704)
PR link: networkservicemesh/sdk-vpp#841
Commit: 5b27c2f
Author: Network Service Mesh Bot
Date: 2024-08-08 05:10:25 -0500
Message:
    - Update go.mod and go.sum to latest version from networkservicemesh/sdk-kernel@main (#841)
PR link: networkservicemesh/sdk-kernel#671
Commit: c7b682d
Author: Network Service Mesh Bot
Date: 2024-08-08 05:06:17 -0500
Message:
        - Update go.mod and go.sum to latest version from networkservicemesh/sdk@main (#671)
PR link: networkservicemesh/sdk#1650
Commit: 3016313
Author: Nikita Skrynnik
Date: 2024-08-08 21:03:55 +1100
Message:
                - Add a timeout for Closes in begin.Server (#1650)
* fix corner cases of the begin chain element
* disable Test_RestartDuringRefresh
* add fresh context
* add extended context
* add refreshed close context everywhere in begin
* fix some unit tests
* unskip some tests
* fix golang linter issues
* debug
* cleanup
* fix race condition
* add unit tests
* fix go linter issues
* fix race conditiong
* apply review comments
---------

Signed-off-by: denis-tingaikin <[email protected]>
Signed-off-by: NikitaSkrynnik <[email protected]>
Signed-off-by: NSMBot <[email protected]>
Co-authored-by: NSMBot <[email protected]>
@nsmbot nsmbot mentioned this pull request Aug 8, 2024
Merged
nsmbot added a commit to networkservicemesh/deployments-k8s that referenced this pull request Aug 8, 2024
@nsmbot
Update go.mod and go.sum to latest version from networkservicemesh/cm…
67ca360 
…d-nse-vl3-vpp@main (#11995)

PR link: networkservicemesh/cmd-nse-vl3-vpp#349

Commit: 1a781f4
Author: Network Service Mesh Bot
Date: 2024-08-08 05:13:36 -0500
Message:
  - Update go.mod and go.sum to latest version from networkservicemesh/sdk-vpp@main (#349)
PR link: networkservicemesh/sdk-vpp#841
Commit: 5b27c2f
Author: Network Service Mesh Bot
Date: 2024-08-08 05:10:25 -0500
Message:
    - Update go.mod and go.sum to latest version from networkservicemesh/sdk-kernel@main (#841)
PR link: networkservicemesh/sdk-kernel#671
Commit: c7b682d
Author: Network Service Mesh Bot
Date: 2024-08-08 05:06:17 -0500
Message:
        - Update go.mod and go.sum to latest version from networkservicemesh/sdk@main (#671)
PR link: networkservicemesh/sdk#1650
Commit: 3016313
Author: Nikita Skrynnik
Date: 2024-08-08 21:03:55 +1100
Message:
                - Add a timeout for Closes in begin.Server (#1650)
* fix corner cases of the begin chain element
* disable Test_RestartDuringRefresh
* add fresh context
* add extended context
* add refreshed close context everywhere in begin
* fix some unit tests
* unskip some tests
* fix golang linter issues
* debug
* cleanup
* fix race condition
* add unit tests
* fix go linter issues
* fix race conditiong
* apply review comments
---------

Signed-off-by: denis-tingaikin <[email protected]>
Signed-off-by: NikitaSkrynnik <[email protected]>
Signed-off-by: NSMBot <[email protected]>
Co-authored-by: NSMBot <[email protected]>
nsmbot added a commit to networkservicemesh/cmd-nse-icmp-responder that referenced this pull request Aug 8, 2024
@nsmbot
Update go.mod and go.sum to latest version from networkservicemesh/sd…
b4d66d2 
…k-sriov@main (#604)

PR link: networkservicemesh/sdk-sriov#602

Commit: 8252927
Author: Network Service Mesh Bot
Date: 2024-08-08 05:11:19 -0500
Message:
  - Update go.mod and go.sum to latest version from networkservicemesh/sdk-kernel@main (#602)
PR link: networkservicemesh/sdk-kernel#671
Commit: c7b682d
Author: Network Service Mesh Bot
Date: 2024-08-08 05:06:17 -0500
Message:
    - Update go.mod and go.sum to latest version from networkservicemesh/sdk@main (#671)
PR link: networkservicemesh/sdk#1650
Commit: 3016313
Author: Nikita Skrynnik
Date: 2024-08-08 21:03:55 +1100
Message:
        - Add a timeout for Closes in begin.Server (#1650)
* fix corner cases of the begin chain element
* disable Test_RestartDuringRefresh
* add fresh context
* add extended context
* add refreshed close context everywhere in begin
* fix some unit tests
* unskip some tests
* fix golang linter issues
* debug
* cleanup
* fix race condition
* add unit tests
* fix go linter issues
* fix race conditiong
* apply review comments
---------

Signed-off-by: denis-tingaikin <[email protected]>
Signed-off-by: NikitaSkrynnik <[email protected]>
Signed-off-by: NSMBot <[email protected]>
Co-authored-by: NSMBot <[email protected]>
nsmbot added a commit to networkservicemesh/cmd-forwarder-sriov that referenced this pull request Aug 8, 2024
@nsmbot
Update go.mod and go.sum to latest version from networkservicemesh/sd…
418a3ad 
…k-sriov@main (#752)

PR link: networkservicemesh/sdk-sriov#602

Commit: 8252927
Author: Network Service Mesh Bot
Date: 2024-08-08 05:11:19 -0500
Message:
  - Update go.mod and go.sum to latest version from networkservicemesh/sdk-kernel@main (#602)
PR link: networkservicemesh/sdk-kernel#671
Commit: c7b682d
Author: Network Service Mesh Bot
Date: 2024-08-08 05:06:17 -0500
Message:
    - Update go.mod and go.sum to latest version from networkservicemesh/sdk@main (#671)
PR link: networkservicemesh/sdk#1650
Commit: 3016313
Author: Nikita Skrynnik
Date: 2024-08-08 21:03:55 +1100
Message:
        - Add a timeout for Closes in begin.Server (#1650)
* fix corner cases of the begin chain element
* disable Test_RestartDuringRefresh
* add fresh context
* add extended context
* add refreshed close context everywhere in begin
* fix some unit tests
* unskip some tests
* fix golang linter issues
* debug
* cleanup
* fix race condition
* add unit tests
* fix go linter issues
* fix race conditiong
* apply review comments
---------

Signed-off-by: denis-tingaikin <[email protected]>
Signed-off-by: NikitaSkrynnik <[email protected]>
Signed-off-by: NSMBot <[email protected]>
Co-authored-by: NSMBot <[email protected]>
nsmbot pushed a commit to networkservicemesh/deployments-k8s that referenced this pull request Aug 8, 2024
Update go.mod and go.sum to latest version from networkservicemesh/cm…
04110df 
…d-nsc-init@main

PR link: networkservicemesh/cmd-nsc-init#764

Commit: fa3cbbf
Author: Network Service Mesh Bot
Date: 2024-08-08 05:14:42 -0500
Message:
  - Update go.mod and go.sum to latest version from networkservicemesh/sdk-sriov@main (#764)
PR link: networkservicemesh/sdk-sriov#602
Commit: 8252927
Author: Network Service Mesh Bot
Date: 2024-08-08 05:11:19 -0500
Message:
    - Update go.mod and go.sum to latest version from networkservicemesh/sdk-kernel@main (#602)
PR link: networkservicemesh/sdk-kernel#671
Commit: c7b682d
Author: Network Service Mesh Bot
Date: 2024-08-08 05:06:17 -0500
Message:
        - Update go.mod and go.sum to latest version from networkservicemesh/sdk@main (#671)
PR link: networkservicemesh/sdk#1650
Commit: 3016313
Author: Nikita Skrynnik
Date: 2024-08-08 21:03:55 +1100
Message:
                - Add a timeout for Closes in begin.Server (#1650)
* fix corner cases of the begin chain element
* disable Test_RestartDuringRefresh
* add fresh context
* add extended context
* add refreshed close context everywhere in begin
* fix some unit tests
* unskip some tests
* fix golang linter issues
* debug
* cleanup
* fix race condition
* add unit tests
* fix go linter issues
* fix race conditiong
* apply review comments
---------
Signed-off-by: denis-tingaikin <[email protected]>
Signed-off-by: NikitaSkrynnik <[email protected]>
Signed-off-by: NSMBot <[email protected]>
@nsmbot nsmbot mentioned this pull request Aug 8, 2024
Merged
nsmbot pushed a commit to networkservicemesh/deployments-k8s that referenced this pull request Aug 8, 2024
Update go.mod and go.sum to latest version from networkservicemesh/cm…
b30a554 
…d-nse-icmp-responder@main

PR link: networkservicemesh/cmd-nse-icmp-responder#604

Commit: b4d66d2
Author: Network Service Mesh Bot
Date: 2024-08-08 05:14:58 -0500
Message:
  - Update go.mod and go.sum to latest version from networkservicemesh/sdk-sriov@main (#604)
PR link: networkservicemesh/sdk-sriov#602
Commit: 8252927
Author: Network Service Mesh Bot
Date: 2024-08-08 05:11:19 -0500
Message:
    - Update go.mod and go.sum to latest version from networkservicemesh/sdk-kernel@main (#602)
PR link: networkservicemesh/sdk-kernel#671
Commit: c7b682d
Author: Network Service Mesh Bot
Date: 2024-08-08 05:06:17 -0500
Message:
        - Update go.mod and go.sum to latest version from networkservicemesh/sdk@main (#671)
PR link: networkservicemesh/sdk#1650
Commit: 3016313
Author: Nikita Skrynnik
Date: 2024-08-08 21:03:55 +1100
Message:
                - Add a timeout for Closes in begin.Server (#1650)
* fix corner cases of the begin chain element
* disable Test_RestartDuringRefresh
* add fresh context
* add extended context
* add refreshed close context everywhere in begin
* fix some unit tests
* unskip some tests
* fix golang linter issues
* debug
* cleanup
* fix race condition
* add unit tests
* fix go linter issues
* fix race conditiong
* apply review comments
---------
Signed-off-by: denis-tingaikin <[email protected]>
Signed-off-by: NikitaSkrynnik <[email protected]>
Signed-off-by: NSMBot <[email protected]>
nsmbot pushed a commit to networkservicemesh/deployments-k8s that referenced this pull request Aug 8, 2024
Update go.mod and go.sum to latest version from networkservicemesh/cm…
80fbd7b 
…d-forwarder-sriov@main

PR link: networkservicemesh/cmd-forwarder-sriov#752

Commit: 418a3ad
Author: Network Service Mesh Bot
Date: 2024-08-08 05:15:00 -0500
Message:
  - Update go.mod and go.sum to latest version from networkservicemesh/sdk-sriov@main (#752)
PR link: networkservicemesh/sdk-sriov#602
Commit: 8252927
Author: Network Service Mesh Bot
Date: 2024-08-08 05:11:19 -0500
Message:
    - Update go.mod and go.sum to latest version from networkservicemesh/sdk-kernel@main (#602)
PR link: networkservicemesh/sdk-kernel#671
Commit: c7b682d
Author: Network Service Mesh Bot
Date: 2024-08-08 05:06:17 -0500
Message:
        - Update go.mod and go.sum to latest version from networkservicemesh/sdk@main (#671)
PR link: networkservicemesh/sdk#1650
Commit: 3016313
Author: Nikita Skrynnik
Date: 2024-08-08 21:03:55 +1100
Message:
                - Add a timeout for Closes in begin.Server (#1650)
* fix corner cases of the begin chain element
* disable Test_RestartDuringRefresh
* add fresh context
* add extended context
* add refreshed close context everywhere in begin
* fix some unit tests
* unskip some tests
* fix golang linter issues
* debug
* cleanup
* fix race condition
* add unit tests
* fix go linter issues
* fix race conditiong
* apply review comments
---------
Signed-off-by: denis-tingaikin <[email protected]>
Signed-off-by: NikitaSkrynnik <[email protected]>
Signed-off-by: NSMBot <[email protected]>
@nsmbot nsmbot mentioned this pull request Aug 8, 2024
Merged
nsmbot added a commit to networkservicemesh/sdk-ovs that referenced this pull request Aug 8, 2024
@nsmbot
Update go.mod and go.sum to latest version from networkservicemesh/sd…
884ad03 
…k-sriov@main (#332)

PR link: networkservicemesh/sdk-sriov#602

Commit: 8252927
Author: Network Service Mesh Bot
Date: 2024-08-08 05:11:19 -0500
Message:
  - Update go.mod and go.sum to latest version from networkservicemesh/sdk-kernel@main (#602)
PR link: networkservicemesh/sdk-kernel#671
Commit: c7b682d
Author: Network Service Mesh Bot
Date: 2024-08-08 05:06:17 -0500
Message:
    - Update go.mod and go.sum to latest version from networkservicemesh/sdk@main (#671)
PR link: networkservicemesh/sdk#1650
Commit: 3016313
Author: Nikita Skrynnik
Date: 2024-08-08 21:03:55 +1100
Message:
        - Add a timeout for Closes in begin.Server (#1650)
* fix corner cases of the begin chain element
* disable Test_RestartDuringRefresh
* add fresh context
* add extended context
* add refreshed close context everywhere in begin
* fix some unit tests
* unskip some tests
* fix golang linter issues
* debug
* cleanup
* fix race condition
* add unit tests
* fix go linter issues
* fix race conditiong
* apply review comments
---------

Signed-off-by: denis-tingaikin <[email protected]>
Signed-off-by: NikitaSkrynnik <[email protected]>
Signed-off-by: NSMBot <[email protected]>
Co-authored-by: NSMBot <[email protected]>
nsmbot added a commit to networkservicemesh/deployments-k8s that referenced this pull request Aug 8, 2024
@nsmbot
Update go.mod and go.sum to latest version from networkservicemesh/cm…
f79db8c 
…d-nsc@main (#12149)

PR link: networkservicemesh/cmd-nsc#640

Commit: 70af2ee
Author: Network Service Mesh Bot
Date: 2024-08-08 05:14:23 -0500
Message:
  - Update go.mod and go.sum to latest version from networkservicemesh/sdk-sriov@main (#640)
PR link: networkservicemesh/sdk-sriov#602
Commit: 8252927
Author: Network Service Mesh Bot
Date: 2024-08-08 05:11:19 -0500
Message:
    - Update go.mod and go.sum to latest version from networkservicemesh/sdk-kernel@main (#602)
PR link: networkservicemesh/sdk-kernel#671
Commit: c7b682d
Author: Network Service Mesh Bot
Date: 2024-08-08 05:06:17 -0500
Message:
        - Update go.mod and go.sum to latest version from networkservicemesh/sdk@main (#671)
PR link: networkservicemesh/sdk#1650
Commit: 3016313
Author: Nikita Skrynnik
Date: 2024-08-08 21:03:55 +1100
Message:
                - Add a timeout for Closes in begin.Server (#1650)
* fix corner cases of the begin chain element
* disable Test_RestartDuringRefresh
* add fresh context
* add extended context
* add refreshed close context everywhere in begin
* fix some unit tests
* unskip some tests
* fix golang linter issues
* debug
* cleanup
* fix race condition
* add unit tests
* fix go linter issues
* fix race conditiong
* apply review comments
---------

Signed-off-by: denis-tingaikin <[email protected]>
Signed-off-by: NikitaSkrynnik <[email protected]>
Signed-off-by: NSMBot <[email protected]>
Co-authored-by: NSMBot <[email protected]>
nsmbot pushed a commit to networkservicemesh/cmd-forwarder-ovs that referenced this pull request Aug 8, 2024
Update go.mod and go.sum to latest version from networkservicemesh/sd…
4cf2ed8 
…k-ovs@main

PR link: networkservicemesh/sdk-ovs#332

Commit: 884ad03
Author: Network Service Mesh Bot
Date: 2024-08-08 05:15:32 -0500
Message:
  - Update go.mod and go.sum to latest version from networkservicemesh/sdk-sriov@main (#332)
PR link: networkservicemesh/sdk-sriov#602
Commit: 8252927
Author: Network Service Mesh Bot
Date: 2024-08-08 05:11:19 -0500
Message:
    - Update go.mod and go.sum to latest version from networkservicemesh/sdk-kernel@main (#602)
PR link: networkservicemesh/sdk-kernel#671
Commit: c7b682d
Author: Network Service Mesh Bot
Date: 2024-08-08 05:06:17 -0500
Message:
        - Update go.mod and go.sum to latest version from networkservicemesh/sdk@main (#671)
PR link: networkservicemesh/sdk#1650
Commit: 3016313
Author: Nikita Skrynnik
Date: 2024-08-08 21:03:55 +1100
Message:
                - Add a timeout for Closes in begin.Server (#1650)
* fix corner cases of the begin chain element
* disable Test_RestartDuringRefresh
* add fresh context
* add extended context
* add refreshed close context everywhere in begin
* fix some unit tests
* unskip some tests
* fix golang linter issues
* debug
* cleanup
* fix race condition
* add unit tests
* fix go linter issues
* fix race conditiong
* apply review comments
---------
Signed-off-by: denis-tingaikin <[email protected]>
Signed-off-by: NikitaSkrynnik <[email protected]>
Signed-off-by: NSMBot <[email protected]>
nsmbot added a commit to networkservicemesh/deployments-k8s that referenced this pull request Aug 8, 2024
@nsmbot
Update go.mod and go.sum to latest version from networkservicemesh/cm…
f784890 
…d-forwarder-sriov@main (#12151)

PR link: networkservicemesh/cmd-forwarder-sriov#752

Commit: 418a3ad
Author: Network Service Mesh Bot
Date: 2024-08-08 05:15:00 -0500
Message:
  - Update go.mod and go.sum to latest version from networkservicemesh/sdk-sriov@main (#752)
PR link: networkservicemesh/sdk-sriov#602
Commit: 8252927
Author: Network Service Mesh Bot
Date: 2024-08-08 05:11:19 -0500
Message:
    - Update go.mod and go.sum to latest version from networkservicemesh/sdk-kernel@main (#602)
PR link: networkservicemesh/sdk-kernel#671
Commit: c7b682d
Author: Network Service Mesh Bot
Date: 2024-08-08 05:06:17 -0500
Message:
        - Update go.mod and go.sum to latest version from networkservicemesh/sdk@main (#671)
PR link: networkservicemesh/sdk#1650
Commit: 3016313
Author: Nikita Skrynnik
Date: 2024-08-08 21:03:55 +1100
Message:
                - Add a timeout for Closes in begin.Server (#1650)
* fix corner cases of the begin chain element
* disable Test_RestartDuringRefresh
* add fresh context
* add extended context
* add refreshed close context everywhere in begin
* fix some unit tests
* unskip some tests
* fix golang linter issues
* debug
* cleanup
* fix race condition
* add unit tests
* fix go linter issues
* fix race conditiong
* apply review comments
---------

Signed-off-by: denis-tingaikin <[email protected]>
Signed-off-by: NikitaSkrynnik <[email protected]>
Signed-off-by: NSMBot <[email protected]>
Co-authored-by: NSMBot <[email protected]>
nsmbot added a commit to networkservicemesh/cmd-nse-vlan-vpp that referenced this pull request Aug 8, 2024
@nsmbot
Update from update/networkservicemesh/sdk-sriov (#490)
e49b203 
* Update go.mod and go.sum to latest version from networkservicemesh/sdk-sriov@main
PR link: networkservicemesh/sdk-sriov#602

Commit: 8252927
Author: Network Service Mesh Bot
Date: 2024-08-08 05:11:19 -0500
Message:
  - Update go.mod and go.sum to latest version from networkservicemesh/sdk-kernel@main (#602)
PR link: networkservicemesh/sdk-kernel#671
Commit: c7b682d
Author: Network Service Mesh Bot
Date: 2024-08-08 05:06:17 -0500
Message:
    - Update go.mod and go.sum to latest version from networkservicemesh/sdk@main (#671)
PR link: networkservicemesh/sdk#1650
Commit: 3016313
Author: Nikita Skrynnik
Date: 2024-08-08 21:03:55 +1100
Message:
        - Add a timeout for Closes in begin.Server (#1650)
* fix corner cases of the begin chain element
* disable Test_RestartDuringRefresh
* add fresh context
* add extended context
* add refreshed close context everywhere in begin
* fix some unit tests
* unskip some tests
* fix golang linter issues
* debug
* cleanup
* fix race condition
* add unit tests
* fix go linter issues
* fix race conditiong
* apply review comments
---------
Signed-off-by: denis-tingaikin <[email protected]>
Signed-off-by: NikitaSkrynnik <[email protected]>
Signed-off-by: NSMBot <[email protected]>

* Automatically resolving conflicts in go.mod and updating dependency versions to the latest

Signed-off-by: NSMBot <[email protected]>

---------

Signed-off-by: denis-tingaikin <[email protected]>
Signed-off-by: NikitaSkrynnik <[email protected]>
Signed-off-by: NSMBot <[email protected]>
Co-authored-by: NSMBot <[email protected]>
nsmbot pushed a commit to networkservicemesh/deployments-k8s that referenced this pull request Aug 8, 2024
Update go.mod and go.sum to latest version from networkservicemesh/cm…
ee22cf3 
…d-nse-vlan-vpp@main

PR link: networkservicemesh/cmd-nse-vlan-vpp#490

Commit: e49b203
Author: Network Service Mesh Bot
Date: 2024-08-08 05:17:31 -0500
Message:
  - Update from update/networkservicemesh/sdk-sriov (#490)
* Update go.mod and go.sum to latest version from networkservicemesh/sdk-sriov@main
PR link: networkservicemesh/sdk-sriov#602
Commit: 8252927
Author: Network Service Mesh Bot
Date: 2024-08-08 05:11:19 -0500
Message:
    - Update go.mod and go.sum to latest version from networkservicemesh/sdk-kernel@main (#602)
PR link: networkservicemesh/sdk-kernel#671
Commit: c7b682d
Author: Network Service Mesh Bot
Date: 2024-08-08 05:06:17 -0500
Message:
        - Update go.mod and go.sum to latest version from networkservicemesh/sdk@main (#671)
PR link: networkservicemesh/sdk#1650
Commit: 3016313
Author: Nikita Skrynnik
Date: 2024-08-08 21:03:55 +1100
Message:
                - Add a timeout for Closes in begin.Server (#1650)
* fix corner cases of the begin chain element
* disable Test_RestartDuringRefresh
* add fresh context
* add extended context
* add refreshed close context everywhere in begin
* fix some unit tests
* unskip some tests
* fix golang linter issues
* debug
* cleanup
* fix race condition
* add unit tests
* fix go linter issues
* fix race conditiong
* apply review comments
---------
Signed-off-by: denis-tingaikin <[email protected]>
Signed-off-by: NikitaSkrynnik <[email protected]>
Signed-off-by: NSMBot <[email protected]>
* Automatically resolving conflicts in go.mod and updating dependency versions to the latest
Signed-off-by: NSMBot <[email protected]>
---------
Signed-off-by: denis-tingaikin <[email protected]>
Signed-off-by: NikitaSkrynnik <[email protected]>
Signed-off-by: NSMBot <[email protected]>
nsmbot added a commit to networkservicemesh/deployments-k8s that referenced this pull request Aug 8, 2024
@nsmbot
Update go.mod and go.sum to latest version from networkservicemesh/cm…
40d30ef 
…d-nse-vlan-vpp@main (#12102)

PR link: networkservicemesh/cmd-nse-vlan-vpp#490

Commit: e49b203
Author: Network Service Mesh Bot
Date: 2024-08-08 05:17:31 -0500
Message:
  - Update from update/networkservicemesh/sdk-sriov (#490)
* Update go.mod and go.sum to latest version from networkservicemesh/sdk-sriov@main
PR link: networkservicemesh/sdk-sriov#602
Commit: 8252927
Author: Network Service Mesh Bot
Date: 2024-08-08 05:11:19 -0500
Message:
    - Update go.mod and go.sum to latest version from networkservicemesh/sdk-kernel@main (#602)
PR link: networkservicemesh/sdk-kernel#671
Commit: c7b682d
Author: Network Service Mesh Bot
Date: 2024-08-08 05:06:17 -0500
Message:
        - Update go.mod and go.sum to latest version from networkservicemesh/sdk@main (#671)
PR link: networkservicemesh/sdk#1650
Commit: 3016313
Author: Nikita Skrynnik
Date: 2024-08-08 21:03:55 +1100
Message:
                - Add a timeout for Closes in begin.Server (#1650)
* fix corner cases of the begin chain element
* disable Test_RestartDuringRefresh
* add fresh context
* add extended context
* add refreshed close context everywhere in begin
* fix some unit tests
* unskip some tests
* fix golang linter issues
* debug
* cleanup
* fix race condition
* add unit tests
* fix go linter issues
* fix race conditiong
* apply review comments
---------



* Automatically resolving conflicts in go.mod and updating dependency versions to the latest

---------

Signed-off-by: denis-tingaikin <[email protected]>
Signed-off-by: NikitaSkrynnik <[email protected]>
Signed-off-by: NSMBot <[email protected]>
Co-authored-by: NSMBot <[email protected]>
nsmbot added a commit to networkservicemesh/cmd-forwarder-ovs that referenced this pull request Aug 8, 2024
@nsmbot
Update go.mod and go.sum to latest version from networkservicemesh/sd…
ac3bbeb 
…k-ovs@main (#392)

PR link: networkservicemesh/sdk-ovs#332

Commit: 884ad03
Author: Network Service Mesh Bot
Date: 2024-08-08 05:15:32 -0500
Message:
  - Update go.mod and go.sum to latest version from networkservicemesh/sdk-sriov@main (#332)
PR link: networkservicemesh/sdk-sriov#602
Commit: 8252927
Author: Network Service Mesh Bot
Date: 2024-08-08 05:11:19 -0500
Message:
    - Update go.mod and go.sum to latest version from networkservicemesh/sdk-kernel@main (#602)
PR link: networkservicemesh/sdk-kernel#671
Commit: c7b682d
Author: Network Service Mesh Bot
Date: 2024-08-08 05:06:17 -0500
Message:
        - Update go.mod and go.sum to latest version from networkservicemesh/sdk@main (#671)
PR link: networkservicemesh/sdk#1650
Commit: 3016313
Author: Nikita Skrynnik
Date: 2024-08-08 21:03:55 +1100
Message:
                - Add a timeout for Closes in begin.Server (#1650)
* fix corner cases of the begin chain element
* disable Test_RestartDuringRefresh
* add fresh context
* add extended context
* add refreshed close context everywhere in begin
* fix some unit tests
* unskip some tests
* fix golang linter issues
* debug
* cleanup
* fix race condition
* add unit tests
* fix go linter issues
* fix race conditiong
* apply review comments
---------

Signed-off-by: denis-tingaikin <[email protected]>
Signed-off-by: NikitaSkrynnik <[email protected]>
Signed-off-by: NSMBot <[email protected]>
Co-authored-by: NSMBot <[email protected]>
nsmbot pushed a commit to networkservicemesh/deployments-k8s that referenced this pull request Aug 8, 2024
Update go.mod and go.sum to latest version from networkservicemesh/cm…
796e025 
…d-forwarder-ovs@main

PR link: networkservicemesh/cmd-forwarder-ovs#392

Commit: ac3bbeb
Author: Network Service Mesh Bot
Date: 2024-08-08 05:19:19 -0500
Message:
  - Update go.mod and go.sum to latest version from networkservicemesh/sdk-ovs@main (#392)
PR link: networkservicemesh/sdk-ovs#332
Commit: 884ad03
Author: Network Service Mesh Bot
Date: 2024-08-08 05:15:32 -0500
Message:
    - Update go.mod and go.sum to latest version from networkservicemesh/sdk-sriov@main (#332)
PR link: networkservicemesh/sdk-sriov#602
Commit: 8252927
Author: Network Service Mesh Bot
Date: 2024-08-08 05:11:19 -0500
Message:
        - Update go.mod and go.sum to latest version from networkservicemesh/sdk-kernel@main (#602)
PR link: networkservicemesh/sdk-kernel#671
Commit: c7b682d
Author: Network Service Mesh Bot
Date: 2024-08-08 05:06:17 -0500
Message:
                - Update go.mod and go.sum to latest version from networkservicemesh/sdk@main (#671)
PR link: networkservicemesh/sdk#1650
Commit: 3016313
Author: Nikita Skrynnik
Date: 2024-08-08 21:03:55 +1100
Message:
                                - Add a timeout for Closes in begin.Server (#1650)
* fix corner cases of the begin chain element
* disable Test_RestartDuringRefresh
* add fresh context
* add extended context
* add refreshed close context everywhere in begin
* fix some unit tests
* unskip some tests
* fix golang linter issues
* debug
* cleanup
* fix race condition
* add unit tests
* fix go linter issues
* fix race conditiong
* apply review comments
---------
Signed-off-by: denis-tingaikin <[email protected]>
Signed-off-by: NikitaSkrynnik <[email protected]>
Signed-off-by: NSMBot <[email protected]>
nsmbot added a commit to networkservicemesh/deployments-k8s that referenced this pull request Aug 8, 2024
@nsmbot
Update go.mod and go.sum to latest version from networkservicemesh/cm…
c9d50f7 
…d-forwarder-ovs@main (#12135)

PR link: networkservicemesh/cmd-forwarder-ovs#392

Commit: ac3bbeb
Author: Network Service Mesh Bot
Date: 2024-08-08 05:19:19 -0500
Message:
  - Update go.mod and go.sum to latest version from networkservicemesh/sdk-ovs@main (#392)
PR link: networkservicemesh/sdk-ovs#332
Commit: 884ad03
Author: Network Service Mesh Bot
Date: 2024-08-08 05:15:32 -0500
Message:
    - Update go.mod and go.sum to latest version from networkservicemesh/sdk-sriov@main (#332)
PR link: networkservicemesh/sdk-sriov#602
Commit: 8252927
Author: Network Service Mesh Bot
Date: 2024-08-08 05:11:19 -0500
Message:
        - Update go.mod and go.sum to latest version from networkservicemesh/sdk-kernel@main (#602)
PR link: networkservicemesh/sdk-kernel#671
Commit: c7b682d
Author: Network Service Mesh Bot
Date: 2024-08-08 05:06:17 -0500
Message:
                - Update go.mod and go.sum to latest version from networkservicemesh/sdk@main (#671)
PR link: networkservicemesh/sdk#1650
Commit: 3016313
Author: Nikita Skrynnik
Date: 2024-08-08 21:03:55 +1100
Message:
                                - Add a timeout for Closes in begin.Server (#1650)
* fix corner cases of the begin chain element
* disable Test_RestartDuringRefresh
* add fresh context
* add extended context
* add refreshed close context everywhere in begin
* fix some unit tests
* unskip some tests
* fix golang linter issues
* debug
* cleanup
* fix race condition
* add unit tests
* fix go linter issues
* fix race conditiong
* apply review comments
---------

Signed-off-by: denis-tingaikin <[email protected]>
Signed-off-by: NikitaSkrynnik <[email protected]>
Signed-off-by: NSMBot <[email protected]>
Co-authored-by: NSMBot <[email protected]>
@rubasov rubasov mentioned this pull request Aug 13, 2024
Open
5 tasks
denis-tingaikin added a commit that referenced this pull request Sep 12, 2024
@denis-tingaikin
Revert "Add a timeout for Closes in begin.Server (#1650)"
4e9cfc4 
This reverts commit 3016313.
denis-tingaikin added a commit that referenced this pull request Sep 13, 2024
@denis-tingaikin
Revert "Add a timeout for Closes in begin.Server (#1650)"
a287a78 
This reverts commit 3016313.
denis-tingaikin added a commit that referenced this pull request Sep 13, 2024
@denis-tingaikin
Revert "Add a timeout for Closes in begin.Server (#1650)"
9275aa5 
This reverts commit 3016313.
NikitaSkrynnik added a commit to NikitaSkrynnik/sdk that referenced this pull request Oct 15, 2024
@NikitaSkrynnik
Revert "Add a timeout for Closes in begin.Server (networkservicemesh#…
a3f8da9 
…1650)"

This reverts commit 3016313.
@NikitaSkrynnik NikitaSkrynnik mentioned this pull request Oct 15, 2024
Merged
9 tasks
NikitaSkrynnik added a commit to NikitaSkrynnik/sdk that referenced this pull request Oct 15, 2024
@NikitaSkrynnik
Revert "Add a timeout for Closes in begin.Server (networkservicemesh#…
6522b19 
…1650)"

This reverts commit 3016313.

Signed-off-by: NikitaSkrynnik <[email protected]>
denis-tingaikin pushed a commit that referenced this pull request Oct 15, 2024
@NikitaSkrynnik
Revert changes in begin and dial (#1682)
083d4e2 
* Revert "Use a context with exteded timeout on Requests in begin (#1656)"

This reverts commit 6fad31a.

Signed-off-by: NikitaSkrynnik <[email protected]>

* Revert "Add a timeout for Closes in begin.Server (#1650)"

This reverts commit 3016313.

Signed-off-by: NikitaSkrynnik <[email protected]>

* Revert "Add more mutexes in dial chain element to fix race conditions (#1670)"

This reverts commit b66e1bf.

Signed-off-by: NikitaSkrynnik <[email protected]>

* fix linter issues

Signed-off-by: NikitaSkrynnik <[email protected]>

---------

Signed-off-by: NikitaSkrynnik <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@denis-tingaikin denis-tingaikin denis-tingaikin approved these changes

@edwarnicke edwarnicke Awaiting requested review from edwarnicke

@ljkiraly ljkiraly Awaiting requested review from ljkiraly

@szvincze szvincze Awaiting requested review from szvincze

@arp-est arp-est Awaiting requested review from arp-est

@bszirtes bszirtes Awaiting requested review from bszirtes

@Ex4amp1e Ex4amp1e Awaiting requested review from Ex4amp1e

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@NikitaSkrynnik @denis-tingaikin