Draft: filter out false subs #124
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This doesn't work because this will always be a cache hit, which means that `get_or_insert` never inserts. Thus, I need to either: 1. force an insertion (and dealloc the old node?) 2. create a new builder? 3. something else Forcing an insertion is probably a good idea since I will eventually need to do something like that for "picking the best" SDD to store at each allocation decision.
Now this makes a worse SDD? I'll port over some of these changes to `main` first...
Merged
mattxwang
added a commit
that referenced
this pull request
Jul 10, 2023
Moves over some changes in #124 to keep things clean! - removes duplicate `UniqueTable` - reverts `backing_store::UniqueTable` to only have `get_or_insert` as part of its interface; move the other methods to just `BackedRobinhoodTable` - tidies up trait bounds (`Eq` implies `PartialEq`, `Debug` is no longer needed) - removes unneeded size check in `get_by_hash`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This doesn't work because this will always be a cache hit, which means that
get_or_insertnever inserts. Thus, I need to either:Forcing an insertion is probably a good idea since I will eventually need to do something like that for "picking the best" SDD to store at each allocation decision.