Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Old tool group component removal, old store removal, and store field rename #383

Merged
merged 3 commits into from
Mar 22, 2023
Merged

Old tool group component removal, old store removal, and store field rename #383

merged 3 commits into from
Mar 22, 2023

Conversation

jarmoza
Copy link
Contributor

@jarmoza jarmoza commented Mar 22, 2023 •
edited
Loading

This PR takes care of #350, #352, and #344 . This is mostly clean up post phase 2 store refactor.

Tool group-like functionality will be restored via custom categories, but for now its unused components are removed from the repo. The old store file was in place for reference and can now be removed. And the columnToCategoryMapping store field is renamed back to columnToCategoryMap - just out of preference and precedent.

@jarmoza jarmoza added deprecation Deprecation and removal of features that are no longer needed. refactor Simplifying or restructuring existing code or documentation. labels Mar 22, 2023
@jarmoza jarmoza requested a review from rmanaem March 22, 2023 19:26
@jarmoza jarmoza changed the title Old tool group component, old store removal, and store field rename Old tool group component removal, old store removal, and store field rename Mar 22, 2023
rmanaem
rmanaem reviewed Mar 22, 2023
View reviewed changes
Copy link
Contributor

@rmanaem rmanaem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good. One thing I noticed in the description is that you mention this PR addresses #354 but there wasn't a change in the eslintrc.js. Perhaps a typo?

@jarmoza
Copy link
Contributor Author

jarmoza commented Mar 22, 2023

@rmanaem That was supposed to be #344 !

@jarmoza jarmoza merged commit 2815dfb into dev_components_talk_to_store_directly Mar 22, 2023
@jarmoza jarmoza deleted the jarmoza-phase2-refactor-cleaning branch March 22, 2023 19:54
This was referenced Mar 22, 2023
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rmanaem rmanaem rmanaem left review comments

Assignees
No one assigned
Labels
deprecation Deprecation and removal of features that are no longer needed. refactor Simplifying or restructuring existing code or documentation.
Projects
Neurobagel
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jarmoza @rmanaem