Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENH] Add NB_MIN_CELL_SIZE env var & reorder env var table for better flow #98

Merged
merged 2 commits into from
Dec 16, 2024

Conversation

alyssadai
Copy link
Contributor

@alyssadai alyssadai commented Dec 16, 2024

Changes proposed in this pull request:

  • Add NB_MIN_CELL_SIZE configuration option to template.env and environment variable table
  • Fix sneaky leftover variable name typo in template.env
  • Reorder environment variable table to group related variables together (like in template.env) and rename "Customization recommended" column to better reflect variables that the user should always change from the default

Checklist

This section is for the PR reviewer

  • PR has an interpretable title with a prefix ([ENH], [FIX], [REF], [TST], [CI], [MNT], [INF], [MODEL], [DOC]) (see our Contributing Guidelines for more info)
  • PR has a label for the release changelog or skip-release (to be applied by maintainers only)
  • PR links to GitHub issue with mention Closes #XXXX
  • Tests pass
  • Checks pass

For new features:

  • Tests have been added

For bug fixes:

  • There is at least one test that would fail under the original bug conditions.

@alyssadai alyssadai added the release Create a release when this PR is merged label Dec 16, 2024
@alyssadai alyssadai requested a review from surchs December 16, 2024 20:59
Copy link
Contributor

@surchs surchs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧑‍🍳

Thanks!

@alyssadai alyssadai added the pr-minor Non-breaking feature or enhancement, will increment minor version (0.+1.0) label Dec 16, 2024
@alyssadai alyssadai merged commit 5de041b into main Dec 16, 2024
@alyssadai alyssadai deleted the add-min-cell-size-config branch December 16, 2024 21:57
Copy link
Contributor

🚀 PR was released in v0.4.0 🚀

@neurobagel-bot neurobagel-bot bot added the released This issue/pull request has been released. label Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-minor Non-breaking feature or enhancement, will increment minor version (0.+1.0) release Create a release when this PR is merged released This issue/pull request has been released.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add environment variable NB_MIN_CELL_SIZE for minimum cell size
2 participants