Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

found another no margin style extension #14

Closed
MarsSwimmer opened this issue Feb 23, 2024 · 4 comments
Closed

found another no margin style extension #14

MarsSwimmer opened this issue Feb 23, 2024 · 4 comments

Comments

@MarsSwimmer
Copy link

os: ubuntu 23.10
executor extension: https://extensions.gnome.org/extension/2932/executor/

截图 2024-02-24 04-44-02

@neuromorph
Copy link
Owner

This extension can be installed directly and is available so that's great!
I had a look at their code and they are not creating a Panel Button but instead creating a custom widget :(.
I will check more details and see if we can have a workaround to apply OpenBar to them.

Thank you for reporting!

@neuromorph
Copy link
Owner

I checked and yes, the issue is they are not using the standard Gnome Top Panel widgets like Panel Button and Bin. Also, as I suspected, the issue is not about margin but mainly about the vertical padding. (Note: For the Global menu one, please try with zero padding to check that as well.)
Unfortunately, I didn't find a good workaround for it and so the fix needs to go into Executor's code. I installed and made some minor changes to their code and now it seems to work fine. I am attaching the code here so you can try it out. It is for the extension.js file of executor extension. You can replace their extension.js file with the attached file
extension.zip
.
I will also submit the change to their repo for their consideration since it would help them with compatibility with custom user themes as well.

Let me know. Thanks.

@MarsSwimmer
Copy link
Author

thank you for your reply, best regard !

@neuromorph
Copy link
Owner

For completeness and further tracking, here is the pull request I submitted to Executor repository. It fixes the issue and also takes steps in the direction they were planning.
Meanwhile, anyone stumbling here with the same issue, you can use the file from PR linked above.
Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants