-
-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Candybar - Gnome shell crash on lock/disable #35
Comments
Hello, Please provide details of which Open Bar version you are using and the Gnome version. Any steps to reproduce? Were you in Overview or Fullscreen mode when system went to sleep? Can you reproduce it by simply locking the screen. Is your Bar on Top or Bottom position? Are using WindowMax Bar? Previously we had faced a Gnome crash issue in fullscreen due to some upstream issue most likely in Mutter but it was fixed. It is important to know as much details as possible to properly investigate within Open Bar or upstream. Thanks. |
Version 29. My system is usually not on fullscreen mode when it goes to sleep. My bar is on the top posiiton, and windowmax is off. It can be reproduced by locking the screen. |
OK, crash without fullscreen or overview is new, Also provide your Gnome version. I will try to recreate the scenario in VM later for the Gnome version you are using. While v29 has been tested earlier but will redo anyway. Also, please try to disable all extensions and then enable only Open Bar to check if it is a conflict issue. Thanks for reporting! |
Yes, you are correct in that GNOME only crashes when candybar is off and I try to put my computer into sleep mode. I tried it with all other extensions disabled and the same thing happened. I'm using a laptop so you can imagine that this happens often, as laptops often go into sleep mode! My Debian system is using GNOME 42.9. Thank you for your help! |
Don't you mean when candybar is 'ON'? I am also using Gnome 42.9 on my laptop with Ubuntu 22.04 LTS. But I am not able to reproduce this crash both with or without candybar. Basically, when laptop sleeps or when you lock screen, Gnome disables the extensions including Open Bar. Try to reproduce the issue just by disabling the Open Bar through an extension manager. If disabling works fine this way then the extension itself does not have an issue but there maybe some conflict occurring when locking (assume lock happens also on sleep).
Thanks. |
(gnome-shell:26539): GLib-GObject-CRITICAL **: 10:43:23.804: g_signal_handler_disconnect: assertion 'handler_id > 0' failed (gnome-shell:26539): libmutter-WARNING **: 10:43:23.833: (../src/backends/meta-barrier.c:275):init_barrier_impl: runtime check failed: (priv->impl) (gnome-shell:26539): libmutter-WARNING **: 10:43:23.833: (../src/backends/meta-barrier.c:275):init_barrier_impl: runtime check failed: (priv->impl) (gnome-shell:26539): libmutter-WARNING **: 10:43:23.833: (../src/backends/meta-barrier.c:275):init_barrier_impl: runtime check failed: (priv->impl) (evolution-addressbook-factory:26673): libedbus-private-WARNING **: 10:43:23.872: Error setting property 'ConnectionStatus' on interface org.gnome.evolution.dataserver.Source: The connection is closed (g-io-error-quark, 18) I just added the relevant parts that led to the crash. Hope that's okay! And yes, I meant that whenever candybar is on, gnome crashes when it is locked. Sorry I misspoke! I don't mean to make things harder for you. |
Hello, Thank you for the log. I saw it but will need to try a few things. Also, I saw you bought me coffees ☕ . Thanks a lot for your support! It is much appreciated 🙏 |
OK, in the beginning there is a Critical log about g_signal_handler. While it does not give trace pointing to OpenBar, I have made some update based on it. There is not much after that to indicate an issue. You will need to use the updated Command to get the update: Let me know how it goes. |
I think I found the problem. I tried changing the palette colors, and discovered that when two colors are the same hex, that's when gnome crashes. However, when I make all the colors different, it's fine. I don't remember what the default colors were, but if they were all different, then I must have made two colors the same somewhere along the line and forgot about it. |
Yes, the default colors were all different for some candy effect. Though, it repeats when you have more than 8 buttons in the bar.
That should not happen. No valid reason for it and also when candybar is off, all buttons have same hex color. However, Gnome/mutter may trip on anything like redrawing of shadow or change in size of bar as styles are removed on lock screen. I forgot to mention in the last comment - you need to logout and log back in for any change in the extension code. So if you tried to update with that command, it will only take effect in new Gnome session (logout/login). I would request you to provide feedback on following points:
Is this reproducible both ways? e.g. crash when same and not when different colors? Thank you, hope to iron it out soon. |
Hey @neuromorph, I experience the same issue on my laptop. The gnome session restarts after I open the lid (resume from sleep) . This happens only when the candybar is enabled. I'll answer the 4 questions soon. Just what do you mean by Gnome version 46 (wayland) |
Hello @StanSvec ,
That is weird and unfortunate. I would certainly like to fix this issue. I am not able to reproduce this issue even when I tried again today with Gnome 45/46. Some specific setup is probably causing it and I would need help to figure it out. If I can get the cause or be able to reproduce it then it will be possible to progress towards fixing it.
Thank you for deciding to help fixing it. I had prepared a small patch for I am currently almost ready with the new version of OpenBar with major updates. So I would request you to test with that to check if issue persists. I have added similar patch to that version as well. You will need to get it from GitHub branch 'openbar2.0' and install manually. Note: you would need to log out and log in again for the new changes to take effect.
Thank you for writing! |
Thanks for the suggestions @neuromorph. What is the procedure for trying the new version?
Something like this? Sorry, I'm not familiar with Gnome internals. Also, is it possible to somehow keep the current configuration? Many thanks |
Hello,
Your current configuration should stay except any changes from the new features that do not exist in the older version (see install procedure below). However, you can export the current settings to a file as backup. After installing new version, you can import this settings file, if needed.
No need to uninstall. Just git clone or download the zip for the 'openbar2.0' branch. Then extract, if zipped, and copy the the extensions directory to overwrite the existing one. The directory should be named as If you face the crash issue in new version as well then you can use the nested shell method and command described in previous post to capture the log. Let me know how it goes. |
Hi, Thanks for the instructions. I've installed the version from the
Any idea what can be wrong? |
Hello,
Well, we need to find the root cause then. What exactly is causing the crash. I can't think of anything special for Candybar.
That is an unrelated issue. You are unable to start the display for the nested shell. Other way of going about it would be to dig into logs after the crash. Which OS are you on? Usually, there will be logs at
Hope this helps. |
Hello @StanSvec and @alq3f , I have good news and better news. Meanwhile, I also tried to do a workaround to avoid the issue from Open Bar and it seems to be holding up. I am not getting the crash now, but it may not be full-proof. While at it, I also fixed some highlight inconsistencies for Candybar and added support to auto-style when some indicators become visible/invisible (e.g. Accessibility). Please get the latest commit from 'openbar2.0' branch and try it out and let me know. |
One more thing, even with the workaround, the issue seems to happen more with the 'Accessibility' indicator in the panel and not really when the indicator is not there. Not sure why that should happen but you may want to try it out. |
Hello @neuromorph , I updated the code from the branch (last commit yesterday 16th), but the issue is not fixed by that even after I removed the Accessibility icon. I'll wait for the Gnome fixes to see if they have any effect then. |
Thank you for reporting! Meanwhile I will try if there is a way to dodge the issue. Also, I think it is not about the Accessibility icon (that wouldn't have made much sense) but I might have faced it since adding the icon increased the number of buttons beyond 8. There are 8 candybar color options currently supported after which it repeats. Event the repeat shouldn't cause any problem at all but some quirkiness of CSS is triggering the main issue in Gnome and I am wondering if that trigger could be avoided. Can you also please try with 8 or less buttons in the panel (disable some extensions/apps) and then see if the crash happens or not. Thank you. |
Quick Update:
Thanks! |
Thanks for the new info @neuromorph. I can see the 16 colours palette in the update, but it doesn't fix the crashing after resume. There are 9 different colours in my panel. |
@StanSvec Thank you for the update. In my test it wouldn't crash on <=8 buttons in panel so I decided to increase the palette but I didn't know how's it would affect. If nothing else it gives additional color options instead of repeating. While there is the upstream bug, I still can't figure out why it affects candybar but not otherwise. There is another update coming soon where the loading and unloading of stylesheet is altered to accommodate NixOS like immutable distros. That might help here too but would need testing. About the upstream merge request, I had added a comment there. We need to compile Gnome shell from source in order to test that fix which I haven't got chance to try yet. On the other hand, they said it will likely be included in Ubuntu 24.04 next month which makes it easier to test and hopefully will become part of Gnome update. |
Hi @neuromorph , I appreciate your effort to have this issue fixed! Fingers crossed the fix will land soon. |
This has been merged into And yes, hoping for the upstream fix soon 👍 |
I have the same issue. Is this fix already released or do I need to use the main branch to fix the problem? |
Hello @coyotle ,
Thank you for reporting! |
@neuromorph sorry for late reply. I'm not sure how to get stack trace. Here is a |
Thanks! This is since there is a bug in the latest Dash-to-dock due to which your log is mostly flooded with only errors from it and is way too big as well. I also switched to Ubuntu dock today when I noticed the issue with Dash-to-dock, hope they'll fix it soon. While you are at it, can you please get the latest Open Bar from the Thank you for getting back! |
ok, I installed OpenBar from the main branch and disabled Dash-to-Dock, but the result is the same, gnome shell is crashing. |
Same here, just updated to Fedora 41 / Gnome 47, installed OpenBar for the first time from https://extensions.gnome.org/extension/6580/open-bar/, and gnome shell crashes when I lock the screen. Unlike the previous issue, I do not have CandyBar turned on. Here are the gnome-shell logs from a "login → attempt to lock screen → crash → login" cycle. Thanks for looking into it! EDIT:Adding the following to "session-modes": ["user", "unlock-dialog"], |
Candybar causes GNOME to crash when system goes into sleep mode.
The text was updated successfully, but these errors were encountered: