Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enabled extension on lock screen #84

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

BigBoyBarney
Copy link

Fixes #35.
Screenshot From 2024-11-01 13-44-58

@neuromorph
Copy link
Owner

Missed to comment here. Thank you for trying out with unlock-dialog and happy to hear that it worked for you!

Unfortunately, some users have reported that it did not work for them, so it is still a bit of question mark.
I was suspecting it should help but there is also a flip side to it due to which I had not added it even after adding some styles for login dialog. The reason is that when screen is locked, Gnome disables extensions using a rebase mechanism. The extensions with "unlock-dialog" are enabled again but the rebasing leads to the extension being disabled and enabled several times depending on the number of extensions the user has and the order in which they were enabled. Long story short, Gnome disables and enables OpenBar several times on screen-lock if we use "unloack-dialog". Since OpenBar has to apply all the styles on enable and remove them on disable, there is much unnecessary overhead happening. This will be true for any other extension in similar situation.

I am keeping it on user mode for now. But I will suggest people to try it out with "unloack-dialog" if they are facing the crash on lock. If mostly it does seem to help the issue then I will take it up.

Meanwhile, if you have been using it with unlock-dialog mode, I would appreciate if you can provide any inputs on if it creates any overload related issues on screen-unlock that may slow the system for a couple seconds etc.

Thank you!

@BigBoyBarney
Copy link
Author

BigBoyBarney commented Dec 8, 2024

Thanks for the explanation. I had no idea Gnome worked like that! :D

I've been using it with unlock-dialog ever since opening this PR and have 0 issues. I have attached a video where I lock and unlock the screen a few times. It's just as smooth as without the extension in my experience and locks instantly.

Video_2024-12-08_20-52-21.mp4

P.S.: Thanks for this extension, it looks stunning 🥳

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Candybar - Gnome shell crash on lock/disable
2 participants