Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attempted to introduce Top Bar bottom margin settings and feature #90

Merged
merged 1 commit into from
Dec 8, 2024

Conversation

atimeofday
Copy link
Contributor

Tentative solution for Issue #88.

This should maintain identical default and current behavior, while introducing two new settings to toggle and adjust a slider for a separate bottom margin value of the Top Bar, for personal preference or compatibility with other extensions such as Forge.

These changes work on my end (so far), but I am rather new to Gnome extension development, so please do double check whether each change is necessary, correct, complete, and properly formatted.

Before:
image

After:
image

New Bottom Margin settings:
image

@neuromorph
Copy link
Owner

Hello,

Thank a lot for your PR, appreciate it!
I glanced through it and it looks like you have properly handled the stylesheets and prefs 👍
Some work will be needed for handling WMax bar and Bar in bottom position. And more testing of course :)
I will merge it now and then work on further updates.
Since you are already using it, if you have found any issues, let me know I will get it sorted.
I will release an update soon, once things are in place.

Thank you, again!

@neuromorph neuromorph merged commit d45d67b into neuromorph:main Dec 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants