Files dat #964
Merged
Files dat #964
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Alternative to old pc.nrnbbcore_write(datpath, gidroups_vector). User does not need to construct, or know the format of, files.dat, when sequentially constructing and writing mod files. When append is 0, files.dat is written from scratch. When append is non-zero, reads existing files.dat, modifies the ngroupids line and appends groupids to end of file. This works also when submodels are constructed by different launches.
Codecov Report
@@ Coverage Diff @@
## master #964 +/- ##
==========================================
- Coverage 27.84% 27.83% -0.01%
==========================================
Files 570 570
Lines 108613 108664 +51
==========================================
+ Hits 30239 30249 +10
- Misses 78374 78415 +41
Continue to review full report at Codecov.
|
|
I'm wondering if the second optional arg, "append", is needed or desireable. Would it be too magical if nrncore_write checks the existence and version of a gidgroup file before writing, to decide whether to append or create from scratch a files.dat file. If an old one exists, it seems reasonable to remove all the [0-9]*.dat files and start afresh. |
pramodk
reviewed
Feb 12, 2021
|
I assume this PR is still work-in-progress. |
|
I got distracted. Will make the changes and ask for a final review. |
Parallel.nrncore_write(path, append) optional second arg must be a number. Resolves reviewer suggestions.
alexsavulescu
approved these changes
Feb 21, 2021
alexsavulescu
pushed a commit
that referenced
this pull request
Apr 13, 2021
…964) * pc.nrncore_write(datpath, append) Alternative to old pc.nrnbbcore_write(datpath, gidroups_vector). User does not need to construct, or know the format of, files.dat, when sequentially constructing and writing mod files. When append is 0, files.dat is written from scratch. When append is non-zero, reads existing files.dat, modifies the ngroupids line and appends groupids to end of file. This works also when submodels are constructed by different launches. * Update ParallelContext.nrncore_write documentation. * Parallel.nrnbbcore_write(path, Vector) deprecated. Parallel.nrncore_write(path, append) optional second arg must be a number.
alexsavulescu
pushed a commit
that referenced
this pull request
Apr 30, 2021
…964) * pc.nrncore_write(datpath, append) Alternative to old pc.nrnbbcore_write(datpath, gidroups_vector). User does not need to construct, or know the format of, files.dat, when sequentially constructing and writing mod files. When append is 0, files.dat is written from scratch. When append is non-zero, reads existing files.dat, modifies the ngroupids line and appends groupids to end of file. This works also when submodels are constructed by different launches. * Update ParallelContext.nrncore_write documentation. * Parallel.nrnbbcore_write(path, Vector) deprecated. Parallel.nrncore_write(path, append) optional second arg must be a number.
olupton
pushed a commit
that referenced
this pull request
Dec 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to neuronsimulator/ringtest#18 where test_submodel.py uses the latest
pc.nrncore_write(path, append)implemented in this pull requestAlternative to old pc.nrnbbcore_write(datpath, gidroups_vector).
User does not need to construct, or know the format of, files.dat, when
sequentially constructing and writing mod files. When append is 0, files.dat
is written from scratch. When append is non-zero, reads existing files.dat,
modifies the ngroupids line and appends groupids to end of file. This
works also when submodels are constructed by different launches.
Updates ParallelContext.nrncore_write documentation