separated types from executable code and modifying the build.mjs file accordingly #105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s file accordingly
shalithasuranga
approved these changes
Mar 18, 2024
There was a problem hiding this comment.
Hi.. @Sadaf-A, Thanks so much for this PR, this is a great improvement to the codebase :taa:
Always a pleasure |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR separates type definitions from executable code and updates the build script -
build.mjsaccordingly. This improves code organization, scalability, and facilitates code reuse. The updated build process ensures the accurate generation of the declaration file. After running the modified file no changes were made to build files which means it functions in the same way.This makes it easier to locate types also and make changes
also using the
typekeyword promotes better documentation, easier refactoring, and overall improved code quality.