⚡ Improve window.setDraggableRegion and add options to allow native-feeling behavior. #120
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes neutralinojs/neutralinojs#1301
TODO:
comment.any
for the changed methods.New call signature:
setDraggableRegion(domElementOrId: string | HTMLElement, options: DraggableRegionOptions = {})
DraggableRegionOptions
isBefore:
Yellow circle indicates mouse clicks. Note how the window misbehaves after releasing the mouse button outside the window.
After, with no options:
Better capture overall but can still break it with flicking near the window's edge.
I can't accept mediocrity, so I added an option to capture the pointer immediately when pressing the drag area. This disables any pointer events on children elements and thus requires layout changes for custom titlebars, so it is opt-in only.
After, with
alwaysCapture: true
Best results: can't break it. Flicking near the edges still captures the pointer.