Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrating ESLint and prettier for code quality and consistency #93

Merged

Conversation

Sadaf-A
Copy link
Contributor

@Sadaf-A Sadaf-A commented Feb 24, 2024

Resolves: #91

This PR integrates ESLint and prettier to our workflow for code quality, consistency and formatting.
This is a common practice in TypeScript projects and it will also ensure the maintainability, readability and cleanliness of the code.

run npm run format for formatting and npm run lint for linting

I have added basic settings for now that can be changed as per preference and I didn't run the commands before this PR as it would make the diff very large and make the PR harder to review

Copy link
Member

@shalithasuranga shalithasuranga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much this idea is great to have well-formatted code 🎉

@shalithasuranga shalithasuranga merged commit ec5f49f into neutralinojs:main Feb 29, 2024
2 checks passed
@Sadaf-A
Copy link
Contributor Author

Sadaf-A commented Feb 29, 2024

Thanks so much this idea is great to have well-formatted code 🎉

Glad to be able to contribute!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Integrate ESLint and Prettier for Code Consistency and Quality
2 participants