Rework governance/ update admin-module NTRN-70 sdk47 #196
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Aug 25, 2023
quasisamurai
changed the title
pr0n00gler
requested changes
Aug 25, 2023
There was a problem hiding this comment.
Please add a tests to check non-whitelisted message will not be executed in proposal
There was a problem hiding this comment.
is it possible to add more tests around authority/signers logic? and what about the list of enabled proposals we removed? I think covering this part with tests wouldn't hurt
sotnikov-s
reviewed
Aug 30, 2023
There was a problem hiding this comment.
is it possible to add more tests around authority/signers logic? and what about the list of enabled proposals we removed? I think covering this part with tests wouldn't hurt
sotnikov-s
approved these changes
Sep 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TASK
Admin module PR
Neutron PR
Neutron SDK PR
Integration tests