-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: flashloans #304
base: feat/sdk-50
Are you sure you want to change the base?
feat: flashloans #304
Conversation
# Conflicts: # package.json
# Conflicts: # package.json
sdk 50 NTRN-230
…tf-v4 chore: bump neutronjsplus to comply with tf v4
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How about finding some way to test if those funds can actually be used in the moment of the loan? I feel that checking only for the end balance of DAO is not really checking that flashloans work
const expiration = new Date(); | ||
expiration.setDate(expiration.getDate() + 1); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is this safe? what would happen if we run integration tests in the last day of a month? will e.g. 31+1 work correct and set the expiration date to the next month's first date?
besides, why even use any expiration in MsgGrant
? wouldn't null be the best option?
JSON.stringify({ | ||
request_loan: { | ||
flashloans_contract: neutronFlashloansAddress, | ||
execution_mode: 1, // MODE_WITHHOLD_LOAN |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
execution_mode: 1, // MODE_WITHHOLD_LOAN | |
execution_mode: 2, // MODE_RETURN_LOAN_MORE_THAN_NECESSARY |
JSON.stringify({ | ||
request_loan: { | ||
flashloans_contract: neutronFlashloansAddress, | ||
execution_mode: 3, // MODE_WITHHOLD_LOAN |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
execution_mode: 3, // MODE_WITHHOLD_LOAN | |
execution_mode: 3, // MODE_REQUEST_ANOTHER_LOAN_RECURSIVELY |
feat: whitelist tf hooks
# Conflicts: # package.json
fix: add test that empty metadata_JSON does not break deserialization #ntrn-346
Feat: icqr dynamic fees
This PR adds tests for the
neutron-flashloans
contract (neutron-org/neutron-dao#105).The following test cases were implemented:
Feel free to suggest more test cases.