Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: pool_metadata proto capitalization #401

Merged
merged 6 commits into from
Apr 26, 2024
Merged

fix: pool_metadata proto capitalization #401

merged 6 commits into from
Apr 26, 2024

Conversation

jcompagni10
Copy link
Contributor

@jcompagni10 jcompagni10 commented Dec 21, 2023 •
edited by pr0n00gler
Loading

@jcompagni10 jcompagni10 changed the base branch from main to fix/proto-dex-allingment December 21, 2023 08:01
pr0n00gler
pr0n00gler previously approved these changes Jan 9, 2024
View reviewed changes
@jcompagni10
Copy link
Contributor Author

https://github.com/neutron-org/neutron-tests/actions/runs/7631859355

@pr0n00gler pr0n00gler changed the base branch from fix/proto-dex-allingment to main January 25, 2024 10:51
@pr0n00gler pr0n00gler dismissed their stale review January 25, 2024 10:51

The base branch was changed.

@swelf19
Copy link
Contributor

swelf19 commented Jan 30, 2024 •
edited
Loading

https://github.com/neutron-org/neutron-tests/actions/runs/7631859355

tests failed Response: {"code":2,"message":"codespace wasm code 9: query wasm contract failed: Error parsing into type neutron_sdk::stargate::dex::types::GetPoolMetadataResponse: missing field Pool_metadata","details":[]}
you need

  1. regenerate https://github.com/neutron-org/neutron-sdk/tree/main/packages/neutron-sdk/src/proto_types, ask @sotnikov-s
  2. update neutron-dev-contracts with new neutron-sdk https://github.com/neutron-org/neutron-dev-contracts/blob/main/Cargo.toml#L16

@pr0n00gler
Copy link
Collaborator

This PR is API breaking and will be merged in the next breaking changes release

@pr0n00gler pr0n00gler marked this pull request as draft February 8, 2024 20:34
@NeverHappened
Copy link
Contributor

has conflicts

@jcompagni10 jcompagni10 changed the base branch from main to feat/sdk-50 March 15, 2024 16:09
@jcompagni10 jcompagni10 marked this pull request as ready for review March 15, 2024 16:09
@pr0n00gler
Copy link
Collaborator

@jcompagni10 please fix conflicts here

This was referenced Apr 25, 2024
Merged
Merged
Merged
@pr0n00gler
Copy link
Collaborator

https://github.com/neutron-org/neutron-tests/actions/runs/8850785311

@pr0n00gler pr0n00gler merged commit 6364e00 into feat/sdk-50 Apr 26, 2024
9 checks passed
@pr0n00gler pr0n00gler mentioned this pull request May 7, 2024
Merged
@pr0n00gler pr0n00gler deleted the fix/pool_metadata_proto branch August 7, 2024 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@swelf19 swelf19 swelf19 approved these changes

@pr0n00gler pr0n00gler pr0n00gler left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jcompagni10 @swelf19 @pr0n00gler @NeverHappened