Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shuttle (New): SSS Izakaya #2002

Open
wants to merge 38 commits into
base: master
Choose a base branch
from

Conversation

AF-Buyrcsp2
Copy link
Contributor

@AF-Buyrcsp2 AF-Buyrcsp2 commented Sep 13, 2024

About the PR

Adds the SSS Izakaya, a japanese-style restaurant/pub ship.

Why / Balance

The name Izakaya come from the real japanese izakaya this design is inspired from, Izakaya is a casual Japanese pub or tavern where people go to enjoy drinks and small plates of food.

Notable Features

  • Huge seating area that can fit up to 44 diners
  • A huge kitchen; a cooking and prep area, beverage area, deep frying area, food storage, tool storage.
  • Small maintenance areas hosting EVA access and Disposals

Shuttle Specifications

  • 1 S.U.P.E.R.P.A.C.M.A.N. Generator
  • 1 Gyroscope
  • 8 Thrusters, 2 for each direction

How to test

Buy at Shipyard Console

Media

uninitialized
image

initialized
image
image

Requirements

  • I have read and I am following the Pull Request Guidelines. I understand that not doing so may get my pr closed at maintainer’s discretion
  • I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Breaking changes

Changelog

🆑 Amfai/Buyrcsp2

  • add: Added the SSS Izakaya

@github-actions github-actions bot added Docs Improvements or additions to documentation Map-Shuttle Map - Shuttle No C# Sprites FTL labels Sep 13, 2024
Copy link
Contributor

github-actions bot commented Sep 13, 2024

RSI Diff Bot; head commit f9e7322 merging into 8a78ea6
This PR makes changes to 1 or more RSIs. Here is a summary of all changes:

Resources/Textures/_NF/Guidebook/shuttle_maps/128x96.rsi

State Old New Status
izakaya Added

Edit: diff updated after f9e7322

@AF-Buyrcsp2 AF-Buyrcsp2 changed the title initial SSS Okamase (NEW) Sep 13, 2024
@AF-Buyrcsp2 AF-Buyrcsp2 marked this pull request as ready for review September 13, 2024 13:21
@AF-Buyrcsp2
Copy link
Contributor Author

hmmm deed issue, what did i miss...

@AF-Buyrcsp2 AF-Buyrcsp2 changed the title SSS Okamase (NEW) SSS Omakase (NEW) Sep 27, 2024
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot added the S: Merge Conflict This PR has conflicts that prevent merging label Sep 30, 2024
@github-actions github-actions bot removed the S: Merge Conflict This PR has conflicts that prevent merging label Sep 30, 2024
@AF-Buyrcsp2
Copy link
Contributor Author

removed the invalid network link, hopefully it is fixed

@github-actions github-actions bot added the S: Merge Conflict This PR has conflicts that prevent merging label Oct 13, 2024
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot removed the S: Merge Conflict This PR has conflicts that prevent merging label Oct 16, 2024
@AF-Buyrcsp2
Copy link
Contributor Author

oops look like i broke things

@AF-Buyrcsp2
Copy link
Contributor Author

how the hell does a comma break so many checks

@dvir001 dvir001 added the Ship Contribution Freeze In effect from 2024-10-14 'til it ends, see https://discord.com/channels/1123826877245694004/1129270 label Dec 18, 2024
@AF-Buyrcsp2
Copy link
Contributor Author

AF-Buyrcsp2 commented Jan 31, 2025

trying out a new theme to find one that has the most "soul"
image

@AF-Buyrcsp2
Copy link
Contributor Author

considering commiting this
image

@AF-Buyrcsp2
Copy link
Contributor Author

renaming to SSS Izakaya...

@AF-Buyrcsp2 AF-Buyrcsp2 changed the title Omakase (New Shuttle) SSS Izakaya (New Shuttle) Feb 2, 2025
@AF-Buyrcsp2
Copy link
Contributor Author

having problems with the ship not spawning

@dustylens
Copy link
Contributor

Did you change the name somewhere?

@AF-Buyrcsp2
Copy link
Contributor Author

latest design
image

@dvir001 dvir001 changed the title SSS Izakaya (New Shuttle) Shuttle (New): SSS Izakaya Feb 21, 2025
@github-actions github-actions bot added the YML label Mar 5, 2025
@MagnusCrowe
Copy link
Contributor

image
All the docking ports seem to be pointed south. The little bubble should be pointed outward.

@MagnusCrowe
Copy link
Contributor

MagnusCrowe commented Mar 5, 2025

So it looks like you haven't fully addressed the issue of over-lighting.

image
This room and the bathroom on the other side have no scrubbers, might want to just remove the doors honestly so you don't need to worry about it, just put up a curtain instead or something like that.

image
This disposal unit is not connected to the network.

image
The air alarm is connected to adjacent rooms, if there's a problem with the atmos in the bridge for example, firelocks will trigger in botany. This may be desirable but the implementation seems incomplete, missing the bridge air alarm and firelocks for example.
image

image
This air alarm isn't connected to anything.

image
image
Don't put firelocks under airlock doors.

image
Missing firelocks under engineering and bridge doors. Also a stray pipe under the wall above the engineering door.

image
Double check all your exterior tiles for vacuum markers.

image
Try not to put buttons behind plants.

image
These posters are perfectly mirrored on the other side, thought it was weird.

I like the new style on the dining room.

@AF-Buyrcsp2
Copy link
Contributor Author

image All the docking ports seem to be pointed south. The little bubble should be pointed outward.

Look like i did a mistake back then, thanks for pointing it out

@AF-Buyrcsp2
Copy link
Contributor Author

AF-Buyrcsp2 commented Mar 5, 2025

So it looks like you haven't fully addressed the issue of over-lighting.

I didn't understand what you are trying to say to me with "over-lighting", until i looked at the new guidelines where it clarifies it, so i will try reducing the lights.

image This room and the bathroom on the other side have no scrubbers, might want to just remove the doors honestly so you don't need to worry about it, just put up a curtain instead or something like that.

Good observation and feedback, ill be applying it.

image This disposal unit is not connected to the network.

Oof rookie mistake for me

image The air alarm is connected to adjacent rooms, if there's a problem with the atmos in the bridge for example, firelocks will trigger in botany. This may be desirable but the implementation seems incomplete, missing the bridge air alarm and firelocks for example. image

More or less one of my first times doing "atmos" in a big shuttle, thank you for the direction

image This air alarm isn't connected to anything.

I could swear i copied the links to that alarm from the old alarm from the previous location

image image Don't put firelocks under airlock doors.

I assume you meant specifically External Airlock? ill be implementing your changes

image Missing firelocks under engineering and bridge doors. Also a stray pipe under the wall above the engineering door.

image Double check all your exterior tiles for vacuum markers.

image Try not to put buttons behind plants.

Noted, thank you.

image These posters are perfectly mirrored on the other side, thought it was weird.

If you are referring to the table side poster, seems like i accidentally mirrored it, as for the "Dojo Sign", its meant to be like an entrance sign, like a restaurant sign, could use your opinion on this though.

I like the new style on the dining room.

I deemed the previous design too weirdly fancy and soulless, so i sought for an alternative aesthetic

@dustylens
Copy link
Contributor

Hi, AF-Buyrcsp2 asked me to take a gander at the lights and such. So I'm going to throw in some thoughts.

  1. Back entrance and maint halls.

ss+(2025-03-05+at+06 20 53)

  • Not sure if the lightbulb under the flap is considered good to go. I'd defer to Magnus on that one. I get the reasoning, given the space available.
  • Given the pipe layout I think you could afford to place an extra scrubber in the airlock. Very helpful for trapped gasses.
  • The naked plating under some airlocks looks a bit out of place. I would use one consistent tileset where possible for my airlock tiles and not employ one that's naked floor and exposed wires.
  • The vents/scrubbers in this space should be linked. Remember! Scrubbers are good!
    ss+(2025-03-05+at+06 13 00)
  • I think most of your o2 lockers could be replaced with o2/n2 lockers. Being said I think we should have a version of those which aren't random fills.
  • Filled maint lockers are problematic : )
    ss+(2025-03-05+at+06 14 43)

Bridge

  • A good example of a lighting reduction possibility. I dropped the number of lights to 1 here and centralized it. This is the end result:
    ss+(2025-03-05+at+06 23 44)
    I feel the space is still perfectly lit with one light over two.
  • I might add a red security frame around your door bolt button.
  • If we're adding firelocks the bridge - kitchen airlock is likely a good place for one. As the bridge has windows and ungrateful customers sometimes have axes.

Kitchen:

  • A nice change for the lights here might be to spread them out a bit. If we take the lights that are directly adjacent:
    ss+(2025-03-05+at+06 36 31)
    And spread them out a little. I was able to illuminate the kitchen with these four spread out lights. Seems ok.
    ss+(2025-03-05+at+06 25 20)
    You have the same number of lights but considerably stronger coverage.
  • Kitchen air alarm could be supplemented by one in the hydro bay
  • You asked about APC placement. Currently it's hidden behind some boxes and vends. You have a pathway leading right up to some empty wall, why not use that space?
    ss+(2025-03-05+at+06 34 16)
  • Health and safety is going to have your rear in a sling for leaving these open janitorial supplies in the kitchen. Stashing a janitorial locker in the spooky maint hallways might be a good carrot to get people to head back there.
    ss+(2025-03-05+at+06 37 30)
  • If you're doubling everything maybe double food-o-mats?

Freezer:

  • At the moment I wouldn't air alarm your freezer. One day we'll need to do something about the pressure but freezer marked spaces compress and trip the alarm. A bother.

Hydro bay:

  • I think you might be able to place an additional air alarm in this space if you wanted a little more granularity over what alarms are connected to which spaces, and connect the local firelocks/vents/scrubbers here.
  • If some spaces seem too bright you might consider moving a light from over the trays to adjacent to the freezer door. As this corner is a bit gloomy.

Engineering:

  • You could probably tap in a vent here.

  • As a small piece to bring to your attention, when both stove sburners are on full your power draw is 38kw, 8 over your default. They pull a lot more juice. I think you're fine, the SMES can keep up for a pretty long time. But eventually you're going to start hitting brownout territory.

  • If you needed a home for the dining room APC it might live in here, so it's not customer facing.

  • Close

At this point I spotted the sideways airlocks and figured that we're going into "this is going to be updated with respect to Magnus feedback".

In general, with respect to the lights specifically, I'd suggest seeing what happens in spaces if you cut the number of lights in half. I don't think that you need to plunge your space into mole people territory but while mapping spaces generally look far more dim than they do in execution.

With respect to the APCs I can understand not wanting a fuse box to be part of the dining experience. I'd lean into the generous space you've allocated for maintenance and power rooms to see if you can find a nice place to help lay cables out.

I think that some of your lockers in the maints section could use a second look.

The gas tank vends are a bit odd.

After you update feel free to give a shout. I don't think I said anything Magnus didn't, but I hope it was helpful.

@dustylens
Copy link
Contributor

A requeted look.

I ended up working a bit late. So it's going to be a brief one.

  1. Something happened to the load times. Whatever you did to fix it last time I'd do it again.
  2. The lighting in some areas has become a bit survival horror-ish.

ss+(2025-03-06+at+08 41 20)
Feels like a warm introduction to your shuttle space without being overbearing.

ss+(2025-03-06+at+08 46 02)

For your maint hallways you'll want to push the doors out 1 tile left/right. That will give you space to put in a light here to maybe make this space less pitch dark.

You can light most spaces with a few lights, if it feels like a space is dark by all means add a light. The hydro bay is a good example of a space that could use at least one more. I know it may feel like an annoying tightrope but I think there's a good middle point between "is there a hydro tray in that corner" and "I need sunglasses indoors".

Close to the finish line now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Docs Improvements or additions to documentation FTL Map-Shuttle Map - Shuttle No C# S: Needs Review This PR is awaiting reviews Ship Contribution Freeze In effect from 2024-10-14 'til it ends, see https://discord.com/channels/1123826877245694004/1129270 size/XL Sprites YML
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants