Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A new medical bag and medical belt crafting recipes. #2981

Merged

Conversation

dustylens
Copy link
Contributor

@dustylens dustylens commented Feb 26, 2025

About the PR

This PR adds a new medical belt bag with medical techfab crafting recipe. It has a whitelists for medical items. This bag is differentiated from the chem bag in that it can only hold small reagent containers but may also carry topicals.

It also adds three recipes to the medical techfab for the medical and paramedic belt in addition to the chem bag. In case you wanted to make a new one.

I did not add a recipe for the web vest as that one seems a bit odd to me. I don't see what it has to do with medicine really.

Why / Balance

The belt recipes felt like they were missing somewhat. The medical bag felt like a nice addition.

After trying to stuff the medical bag with a few things I gave it a slight size increase over the chem bag. Let me know if that seems a bit over the top.

How to test

Print the bags.

Give the whitelist a bit of a stress test. I think it's generally good to go but the -bottle tag might cause issues I didn't catch after work.

Media

ss+(2025-02-26+at+08 06 33)

Requirements

Breaking changes

Changelog

🆑

  • add: New medical bag and crafting recipes for chem bag and medical belts.

Copy link
Contributor

github-actions bot commented Feb 26, 2025

RSI Diff Bot; head commit ff949db merging into 20cbb5d
This PR makes changes to 1 or more RSIs. Here is a summary of all changes:

Resources/Textures/_NF/Objects/Specific/Medical/medical_bag.rsi

State Old New Status
equipped-BELT Added
icon-on Added
icon Added
inhand-left Added
inhand-right Added

Edit: diff updated after ff949db

@dustylens dustylens marked this pull request as draft February 26, 2025 14:58
@dustylens dustylens marked this pull request as ready for review February 27, 2025 14:53
@github-actions github-actions bot added the S: Merge Conflict This PR has conflicts that prevent merging label Mar 1, 2025
Copy link
Contributor

github-actions bot commented Mar 1, 2025

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot removed the S: Merge Conflict This PR has conflicts that prevent merging label Mar 1, 2025
Copy link
Contributor

@ErhardSteinhauer ErhardSteinhauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added some notes for your consideration, changes are not required.

components:
- Pill
- Hypospray
tags:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You might consider adding GlassBeaker tag. Also for some reason chembag doesn't have this tag.

Copy link
Contributor Author

@dustylens dustylens Mar 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For this specific bag I thought it might be more appropriate to limit the contents to vials. What do you think?

The chembag uses the FitsInDispenser component to handle its beaker needs I believe.

Copy link
Contributor

@ErhardSteinhauer ErhardSteinhauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works

Copy link
Contributor

@whatston3 whatston3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems alright, the bag magnet stuff might be useful to separate into a parent, but this is good.

@ErhardSteinhauer ErhardSteinhauer merged commit ec2fa64 into new-frontiers-14:master Mar 5, 2025
15 checks passed
FrontierATC added a commit that referenced this pull request Mar 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants