-
Notifications
You must be signed in to change notification settings - Fork 654
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
A new medical bag and medical belt crafting recipes. #2981
A new medical bag and medical belt crafting recipes. #2981
Conversation
RSI Diff Bot; head commit ff949db merging into 20cbb5d Resources/Textures/_NF/Objects/Specific/Medical/medical_bag.rsi
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added some notes for your consideration, changes are not required.
Resources/Prototypes/_NF/Entities/Objects/Specific/Medical/medical_bag.yml
Outdated
Show resolved
Hide resolved
components: | ||
- Pill | ||
- Hypospray | ||
tags: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You might consider adding GlassBeaker
tag. Also for some reason chembag doesn't have this tag.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For this specific bag I thought it might be more appropriate to limit the contents to vials. What do you think?
The chembag uses the FitsInDispenser
component to handle its beaker needs I believe.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems alright, the bag magnet stuff might be useful to separate into a parent, but this is good.
About the PR
This PR adds a new medical belt bag with medical techfab crafting recipe. It has a whitelists for medical items. This bag is differentiated from the chem bag in that it can only hold small reagent containers but may also carry topicals.
It also adds three recipes to the medical techfab for the medical and paramedic belt in addition to the chem bag. In case you wanted to make a new one.
I did not add a recipe for the web vest as that one seems a bit odd to me. I don't see what it has to do with medicine really.
Why / Balance
The belt recipes felt like they were missing somewhat. The medical bag felt like a nice addition.
After trying to stuff the medical bag with a few things I gave it a slight size increase over the chem bag. Let me know if that seems a bit over the top.
How to test
Print the bags.
Give the whitelist a bit of a stress test. I think it's generally good to go but the -bottle tag might cause issues I didn't catch after work.
Media
Requirements
Breaking changes
Changelog
🆑