-
Notifications
You must be signed in to change notification settings - Fork 654
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Lathe Recipes: Clothing Edition #3032
base: master
Are you sure you want to change the base?
Conversation
Might be worth splitting those recipes into new lathe categories for ease of navigation (like, "military jumpsuits", "Informal", "Color"). |
4ea7d9f
to
50681c8
Compare
Splitted them into 3 Categories. |
What I meant was adding new categories to lathe recipes. In order to do so, you'd need to add new lines to this 2 files: And the create new parents for recipes you've added. |
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Found a few odd inconsistencies.
Probably still missing things - e.g. no flannel jackets? (ClothingOuterFlannelRed, Green, Blue)
Prototype bloat aside, the fact all the recipes parent off of the base jumpsuit is nice.
The only issue I have with this is bloat. There is no hard line here.
- ClothingUniformJumpsuitScientistFormal | ||
- ClothingUniformJumpsuitTshirtJeans | ||
- ClothingUniformJumpsuitHawaiYellow |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No HawaiRed/Black?
- ClothingUniformJumpskirtRedStripedDress | ||
- ClothingUniformJumpskirtRedTurtleneckDress | ||
- ClothingUniformJumpsuitRepairmanNT |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Interestingly, this is the only source of this suit as far as I can tell.
Make an emag pack with the syndie version. :^)
- ClothingUniformJumpskirtCasualPurple | ||
- ClothingUniformJumpsuitCasualPurple | ||
- ClothingUniformJumpskirtCasualRed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing JumpsuitCasualRed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So funny enough, Red Jumpsuit is already in the Uniform Printer, Unsure if i add it here that the Linter & Build would scream again, could also be wrong
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If your list is as extensive as this, and the goal of the list is to be "here's just about everything you can print off", at what point do you deprecate the use of the old list in the machine vs. saying "no, remember, this recipe is in the upstream pack here"
- ClothingUniformJumpskirtRedElegantDress | ||
- ClothingUniformJumpskirtRedStripedDress | ||
- ClothingUniformJumpskirtRedTurtleneckDress |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No OrangeStripedDress?
- ClothingUniformJumpskirtGreenTurtleneckDress | ||
- ClothingUniformJumpsuitJournalist | ||
- ClothingUniformJumpsuitMonasticRobeLight |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No MonasticRobeDark?
- ClothingUniformJumpskirtBlueElegantDress | ||
- ClothingUniformJumpsuitHawaiBlue | ||
- ClothingUniformJumpsuitSecBlue |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consider moving ClothingUniformJumpsuitPrivateSec and ClothingUniformJumpskirtPrivateSec.
@@ -8,6 +8,9 @@ | |||
- MedicalAppraisalTool | |||
- HandheldCrewMonitor | |||
- PowerCellSmall # For small appliances, convenience if anything | |||
- UniformScrubsColorBlue | |||
- UniformScrubsColorGreen | |||
- UniformScrubsColorPurple |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consider adding ClothingOuterHospitalGown.
Consider adding this in a separate feature after the upstream merge. Lathe recipes support multiple categories then. |
Fair |
About the PR
Adds some more Clothing to the Uniform Printer.
Also adds 3 to the Medical Fabricator
Uniform list was made by Kameron, who also requested this.
Why / Balance
To be able to Annoy the SR to print clothes (joke)
Allows the SR to actually print more Clothes that might be more fitting for a specific moment
How to test
Media
Requirements
Breaking changes
Changelog
🆑