Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lathe Recipes: Clothing Edition #3032

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

Myzumi
Copy link
Contributor

@Myzumi Myzumi commented Mar 5, 2025

About the PR

Adds some more Clothing to the Uniform Printer.
Also adds 3 to the Medical Fabricator

Uniform list was made by Kameron, who also requested this.

Why / Balance

To be able to Annoy the SR to print clothes (joke)
Allows the SR to actually print more Clothes that might be more fitting for a specific moment

How to test

  • Spawn
  • Select
  • Print
  • Profit

Media

Requirements

Breaking changes

Changelog

🆑

  • tweak: Uniform Printer Received some new Uniforms
  • tweak: Medical Fabricator Received 3 Scrub Clothes

@ErhardSteinhauer
Copy link
Contributor

ErhardSteinhauer commented Mar 5, 2025

Might be worth splitting those recipes into new lathe categories for ease of navigation (like, "military jumpsuits", "Informal", "Color").

@github-actions github-actions bot added the size/M label Mar 5, 2025
@Myzumi Myzumi force-pushed the clothing-lathe-recipes branch from 4ea7d9f to 50681c8 Compare March 5, 2025 16:19
@Myzumi
Copy link
Contributor Author

Myzumi commented Mar 5, 2025

Might be worth splitting those recipes into new lathe categories for ease of navigation (like, "military jumpsuits", "Informal", "Color").

Splitted them into 3 Categories.

@ErhardSteinhauer
Copy link
Contributor

What I meant was adding new categories to lathe recipes. In order to do so, you'd need to add new lines to this 2 files:
https://github.com/new-frontiers-14/frontier-station-14/blob/master/Resources/Prototypes/_NF/Recipes/Lathes/categories.yml
https://github.com/new-frontiers-14/frontier-station-14/blob/master/Resources/Locale/en-US/_NF/lathe/lathe-categories.ftl

And the create new parents for recipes you've added.

Copy link
Contributor

github-actions bot commented Mar 5, 2025

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot added the S: Merge Conflict This PR has conflicts that prevent merging label Mar 5, 2025
@github-actions github-actions bot removed the S: Merge Conflict This PR has conflicts that prevent merging label Mar 5, 2025
Copy link
Contributor

@whatston3 whatston3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found a few odd inconsistencies.

Probably still missing things - e.g. no flannel jackets? (ClothingOuterFlannelRed, Green, Blue)

Prototype bloat aside, the fact all the recipes parent off of the base jumpsuit is nice.

The only issue I have with this is bloat. There is no hard line here.

- ClothingUniformJumpsuitScientistFormal
- ClothingUniformJumpsuitTshirtJeans
- ClothingUniformJumpsuitHawaiYellow
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No HawaiRed/Black?

- ClothingUniformJumpskirtRedStripedDress
- ClothingUniformJumpskirtRedTurtleneckDress
- ClothingUniformJumpsuitRepairmanNT
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interestingly, this is the only source of this suit as far as I can tell.

Make an emag pack with the syndie version. :^)

- ClothingUniformJumpskirtCasualPurple
- ClothingUniformJumpsuitCasualPurple
- ClothingUniformJumpskirtCasualRed
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing JumpsuitCasualRed.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So funny enough, Red Jumpsuit is already in the Uniform Printer, Unsure if i add it here that the Linter & Build would scream again, could also be wrong

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If your list is as extensive as this, and the goal of the list is to be "here's just about everything you can print off", at what point do you deprecate the use of the old list in the machine vs. saying "no, remember, this recipe is in the upstream pack here"

- ClothingUniformJumpskirtRedElegantDress
- ClothingUniformJumpskirtRedStripedDress
- ClothingUniformJumpskirtRedTurtleneckDress
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No OrangeStripedDress?

- ClothingUniformJumpskirtGreenTurtleneckDress
- ClothingUniformJumpsuitJournalist
- ClothingUniformJumpsuitMonasticRobeLight
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No MonasticRobeDark?

- ClothingUniformJumpskirtBlueElegantDress
- ClothingUniformJumpsuitHawaiBlue
- ClothingUniformJumpsuitSecBlue
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider moving ClothingUniformJumpsuitPrivateSec and ClothingUniformJumpskirtPrivateSec.

@@ -8,6 +8,9 @@
- MedicalAppraisalTool
- HandheldCrewMonitor
- PowerCellSmall # For small appliances, convenience if anything
- UniformScrubsColorBlue
- UniformScrubsColorGreen
- UniformScrubsColorPurple
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider adding ClothingOuterHospitalGown.

@whatston3
Copy link
Contributor

What I meant was adding new categories to lathe recipes. In order to do so, you'd need to add new lines to this 2 files: https://github.com/new-frontiers-14/frontier-station-14/blob/master/Resources/Prototypes/_NF/Recipes/Lathes/categories.yml https://github.com/new-frontiers-14/frontier-station-14/blob/master/Resources/Locale/en-US/_NF/lathe/lathe-categories.ftl

And the create new parents for recipes you've added.

Consider adding this in a separate feature after the upstream merge. Lathe recipes support multiple categories then.

@ErhardSteinhauer
Copy link
Contributor

What I meant was adding new categories to lathe recipes. In order to do so, you'd need to add new lines to this 2 files: https://github.com/new-frontiers-14/frontier-station-14/blob/master/Resources/Prototypes/_NF/Recipes/Lathes/categories.yml https://github.com/new-frontiers-14/frontier-station-14/blob/master/Resources/Locale/en-US/_NF/lathe/lathe-categories.ftl
And the create new parents for recipes you've added.

Consider adding this in a separate feature after the upstream merge. Lathe recipes support multiple categories then.

Fair

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants